From 5e5f7110862f93017d12c23f58730d571bf264f4 Mon Sep 17 00:00:00 2001 From: nilehmann Date: Tue, 6 Aug 2024 03:24:38 +0000 Subject: [PATCH] =?UTF-8?q?Deploying=20to=20gh-pages=20from=20@=20flux-rs/?= =?UTF-8?q?flux@f4c615be45cc9704239361fb08163afe622e1372=20=F0=9F=9A=80?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- doc/flux_middle/queries/enum.QueryErr.html | 4 ++-- doc/help.html | 2 +- doc/index.html | 2 +- doc/settings.html | 2 +- doc/src/flux_middle/queries.rs.html | 4 ++-- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/flux_middle/queries/enum.QueryErr.html b/doc/flux_middle/queries/enum.QueryErr.html index d3207a6bee..0c10330fbd 100644 --- a/doc/flux_middle/queries/enum.QueryErr.html +++ b/doc/flux_middle/queries/enum.QueryErr.html @@ -25,12 +25,12 @@

Other errors are better reported at the use-site. For example, if some code calls a function from an external crate that has unsupported features, we ought to report the error at the call-site, because it would be confusing to only mention the definition of the external function without -showing which part of the code is calling it. To attach a span to error one can use QueryErr::at +showing which part of the code is calling it. To attach a span to an error one can use QueryErr::at to get a QueryErrAt.

Both QueryErr and QueryErrAt implement Diagnostic. The implementation for QueryErr reports the error at the definition site, while the implementation for QueryErrAt reports it at the (attached) use-site span. This allows to play a bit lose because we can emit an error without -attatching an span, but this means we may forget to attach spans at some places. We should consider +attatching a span, but this means we may forget to attach spans at some places. We should consider not implementing Diagnostic for QueryErr such that we always make the distinction between use-site and def-site explicit, e.g., we could have methods QueryErr::at_use_site and QueryErr::at_def_site returning types with different implementations of Diagnostic.

diff --git a/doc/help.html b/doc/help.html index 98442eac87..006a0297ed 100644 --- a/doc/help.html +++ b/doc/help.html @@ -1 +1 @@ -Help

Rustdoc help

Back
\ No newline at end of file +Help

Rustdoc help

Back
\ No newline at end of file diff --git a/doc/index.html b/doc/index.html index acc3f22079..c6ccfc0870 100644 --- a/doc/index.html +++ b/doc/index.html @@ -1 +1 @@ -Index of crates

List of all crates

\ No newline at end of file +Index of crates

List of all crates

\ No newline at end of file diff --git a/doc/settings.html b/doc/settings.html index 46a19c024d..ad7e294d89 100644 --- a/doc/settings.html +++ b/doc/settings.html @@ -1 +1 @@ -Settings

Rustdoc settings

Back
\ No newline at end of file +Settings

Rustdoc settings

Back
\ No newline at end of file diff --git a/doc/src/flux_middle/queries.rs.html b/doc/src/flux_middle/queries.rs.html index 65926ed0a2..5b39351264 100644 --- a/doc/src/flux_middle/queries.rs.html +++ b/doc/src/flux_middle/queries.rs.html @@ -796,13 +796,13 @@ /// Other errors are better reported at the use-site. For example, if some code calls a function from /// an external crate that has unsupported features, we ought to report the error at the call-site, /// because it would be confusing to only mention the definition of the external function without -/// showing which part of the code is calling it. To attach a span to error one can use [`QueryErr::at`] +/// showing which part of the code is calling it. To attach a span to an error one can use [`QueryErr::at`] /// to get a [`QueryErrAt`]. /// /// Both [`QueryErr`] and [`QueryErrAt`] implement [`Diagnostic`]. The implementation for [`QueryErr`] /// reports the error at the definition site, while the implementation for [`QueryErrAt`] reports it at /// the (attached) use-site span. This allows to play a bit lose because we can emit an error without -/// attatching an span, but this means we may forget to attach spans at some places. We should consider +/// attatching a span, but this means we may forget to attach spans at some places. We should consider /// not implementing [`Diagnostic`] for [`QueryErr`] such that we always make the distinction between /// use-site and def-site explicit, e.g., we could have methods `QueryErr::at_use_site` and /// `QueryErr::at_def_site` returning types with different implementations of [`Diagnostic`].