Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move include files to cbits directory #2

Open
conklech opened this issue Nov 23, 2014 · 4 comments
Open

Move include files to cbits directory #2

conklech opened this issue Nov 23, 2014 · 4 comments

Comments

@conklech
Copy link

I've been poking at a Windows port. Either because I'm on Windows or because I'm using a cabal sandbox, the current include-dirs: arrangement doesn't work for me. The path "./" doesn't work with #include "include/internal/...h". The documentation for Cabal is kind of useless in this regard.

I had to move the include files into a new directory, "cbits", and adjust the include-dirs accordingly.

I also added the include files to the extra-source-files field in the cabal file.

I tried to make a pull request for this issue, but GitHub is being weird (and/or you can't make a pull request to a single commit?) You can see my solution to this issue (and some other commits to get some things building) on my fork.

@fluffynukeit
Copy link
Owner

Hmm you should be able to pull request a single commit. conklech/bindings-cef3@73102a5. I'll check that out later today to make sure that your updates still work on my Linux box. I'll just have to assume it works for Windows generally because I can't test that part of it. Thanks for the contribution!

@conklech
Copy link
Author

Well, it "works" in that it moves the build along to another failure point on Windows; I posted this issue mainly in case it's a sandboxing problem not a Windows problem. As an aside, on my master in Windows I'm failing in CefTypesLinux.hsc, which is unsurprising. I won't likely have time to make much progress until mid-December. I'm also not sure the available Windows binaries for CEF itself will work with GHC--they're build with MSVC--so there may be a bit of work involved in getting a workable Windows solution, unfortunately.

@conklech
Copy link
Author

Oh, and I'm not suggesting you pull the commits that include cef_types_win.h and modify cef_types.h. Sorry; I'm a bit rusty with Github.

@fluffynukeit
Copy link
Owner

No worries :). I'm glad someone is looking at the windows case. I originally envisioned using it for development on linux and deployment on windows. I myself haven't done much of anything with this library since I announced it. There are a lot of cool, recent frameworks that do stuff along these lines like atom-shell and thrust, and purescript is capturing my attention at the moment.

If you do manage to get a build on Windows, I'd be interested in knowing how you did it. We can put some instructions on the wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants