-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.0 release (beta) #113
Comments
Is this the release that adds OpenApi 3.0 support? |
Hi, OA3.0 is not part of the 5.0 release (yet), I'm preparing the codebase for it, but I'll need to broader up the test suite and also decide if we'll support both versions side by side or convert v2 to v3 before generating (2nd is preferred). It would help if you could share what API are you planning to use the generator on (if can be shared). Feel free to reach out via email. If your definition is not sharable, my call for public OA3.0+ version API definitions is still on |
@vmasek I have just transitioned from 4.x to Should I be aware of any breaking changes in behavior that I am missing right now? |
@hoebbelsB only breaking change there should be at this moment are moved interfaces mentioned here https://github.com/flowup/api-client-generator/releases/tag/5.0.0-beta.0 There might be more to come but I'll try to keep it on a minimum for the final release. |
thanks :) |
A hiccup I just encountered: query-param lists are now generated as ?param=value,value whereas previously he would generate ?param=value¶m=value But that's probably something that we will just change in our api. |
@Mvrlex could you have a look on your swagger file if there is |
Adding the collectionFormat unfortunately did not change the generation behaviour. This is the input (obscured): /v0/bla:
get:
operationId: getBla
parameters:
- name: expandables
in: query
type: array
collectionFormat: multi
items:
type: string
enum: [val1, val2]
required: false This is the output: if ('expandables' in args) {
options.params = options.params.set('expandables', String(args.expandables));
} |
@Mvrlex thanks, I'll try to have a look at this feature soon as it is definitely needed for the release and needs to be tested in time |
Beta version of the generator has been released, it brings many fixes and improvements. Please test this version and report inconsistencies/bugs so we can fix them for the final release
The text was updated successfully, but these errors were encountered: