Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh_CN support #86

Open
ccat3z opened this issue Nov 15, 2020 · 4 comments · May be fixed by #87
Open

zh_CN support #86

ccat3z opened this issue Nov 15, 2020 · 4 comments · May be fixed by #87

Comments

@ccat3z
Copy link

ccat3z commented Nov 15, 2020

Is it possible to support language extensions like com.wps.Office.Locale.zh_CN by mount zh_CN mui packages at extra/wps-office/office6/mui/zh_CN? Here is the method to support Chinese on ArchLinux.

@gasinvein
Copy link
Member

It adds locale from Chinese version to international version, right? I believe Chinese version altogether should be submitted to Flathub as a separate app, e.g. cn.wps.Office.

@ccat3z
Copy link
Author

ccat3z commented Nov 15, 2020

I think it is not necessary to submit a separate app. The international version and the Chinese version are very similar. their differences are as follows:

# en: https://wdl1.pcfg.cache.wpscdn.com/wpsdl/wpsoffice/download/linux/9719/wps-office_11.1.0.9719.XA_amd64.deb
# sha256: b3dc6494172b5d64261227049edc06e9b1f90556b6a0dbd43f0daa32648c46e7
# cn: https://wdl1.cache.wps.cn/wps/download/ep/Linux2019/9719/wps-office_11.1.0.9719_amd64.deb
# sha256: e75cca44a00fae3df5a040d139bb942acdacb8dfb9b68b9052bde5516aca7eae
> diff -rq en cn
Files en/opt/kingsoft/wps-office/office6/cfgs/oem.ini and cn/opt/kingsoft/wps-office/office6/cfgs/oem.ini differ
Files en/opt/kingsoft/wps-office/office6/mui/default/EULA_linux.html and cn/opt/kingsoft/wps-office/office6/mui/default/EULA_linux.html differ
Files en/opt/kingsoft/wps-office/office6/mui/default/Privacy_Linux.html and cn/opt/kingsoft/wps-office/office6/mui/default/Privacy_Linux.html differ
Only in cn/opt/kingsoft/wps-office/office6/mui/en_US: EULA_linux.html
Only in cn/opt/kingsoft/wps-office/office6/mui/en_US: Privacy_Linux.html
Only in cn/opt/kingsoft/wps-office/office6/mui/en_US/resource: help
Only in cn/opt/kingsoft/wps-office/office6/mui: zh_CN

The Chinese version add Chinese license files (EULA, Privacy) and Chinese language packs. The others are completely same.

@gasinvein
Copy link
Member

Well, the app versions were separated on purpose, so I still think they should be separate flatpaks as well. But anyway, I guess we can add an extension point for MUI, it probably won't hurt.

@ccat3z
Copy link
Author

ccat3z commented Nov 15, 2020

OK. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants