[firebase_messaging]: Remove references to deprecated v1 Android embedding

[reidbaker]

Is there an existing issue for this?

• I have searched the existing issues.

Which plugins are affected?

Messaging

Which platforms are affected?

Android

Description

To ensure this plugin will work with users running the next stable version of Flutter remove references to the v1 embedding.

The v1 embedding was deprecated around 6 and a half years ago. In Flutter 3.22, the Flutter tool dropped support for building v1 apps entirely. Flutter plans to delete version one of it's Android embedding in the next stable release, per https://medium.com/flutter/whats-new-in-flutter-3-22-fbde6c164fe3 (in the "Removal of v1 Android embedding" section).

When that deletion happens, any apps using plugins that still have references to the removed classes will fail to build when updating to the next stable version (probably Flutter 3.26).

As a part of this deprecation, the Flutter Android team is doing community outreach by filing bugs and submitting some pull requests to update plugins to minimize the impact this removal has on the community.

Some example PRs:

• Flutter team maintained plugins: [many] Remove references to v1 embedding flutter/packages#6494
• android_alarm_manager_plus fix(android_alarm_manager_plus): Remove references to v1 embedding fluttercommunity/plus_plugins#2864

Consequences:

• This change should have no impact on users of this plugin that are building apps using the v2 embedding (we don't have a percentage to share, but this is the vast majority of users).
• It will remove support for users that are still using the v1 embedding on version of Flutter older than 3.22.

If this change doesn't land, this plugin will instead be broken for all apps building on the next stable version of Flutter and beyond.

Is there a way to support both v1 and v2 embedding apps in the next stable version of Flutter?

No.

This is the PR where we are removing the deprecated engine classes: flutter/engine#52022

Reproducing the issue

Build Messaging with a custom engine version targeting flutter/engine#52022

Firebase Core version

tip of tree

Flutter Version

3.26

Relevant Log Output

No response

Flutter dependencies

Expand Flutter dependencies snippet

N/A

Additional context and comments

No response

[reidbaker]

https://github.com/search?q=repo%3Afirebase%2Fflutterfire%20(%22io.flutter.view.FlutterMain%22%20OR%20%22io.flutter.view.FlutterNativeView%22%20OR%20%22io.flutter.view.FlutterView%22%20OR%20%22io.flutter.embedding.engine.plugins.shim%22%20OR%20%22io.flutter.app%22%20OR%20%22PluginRegistry.Registrar%22)&type=code

The only instances in this plugin are dart docs.

[reidbaker]

Confirmed compilation against the version of the engine with the classes removed.

[Lyokone]

Thanks for checking @reidbaker, if I understand properly, the only thing that we still have to do is remove the references in documentation?

[reidbaker]

Correct. I debated not filing an issue at all since it wont cause issues for your customers but figured you might want to know you are referencing classes that will not exist in the future :).

[Lyokone]

Thanks for taking the time to check :)