Feature: Add support for SFTP

[Tombstone2K]

Requirements

• Enabled add new SFTP connections (should follow the same UX as FTP)

[benjione]

I think this is a duplicate of #1629 and was merged with #1342 . However, FTP is not the same as SFTP. I suggest merging this with #1342 .

[ttmx]

This would be extremely nice and would remove the need for Filezilla and the likes, making it a much more uniform and convenient experience.

[yaira2]

What are the requirements for this feature (eg. how do you expect this feature to work)?

[hez2010]

We can integrate SSH.NET and do what we have done for FTP before.
But we need to wait for the next release of SSH.NET for asynchronous IO support.

[yaira2]

Isn't our current implementation of FTP a little slow or am I thinking of regular network drives?

[hez2010]

Isn't our current implementation of FTP a little slow

You're right. I'm expecting FluentFTP to use IAsyncEnumerable to list files from FTP in the future, instead of listing all entries at once.

[yaira2]

We can integrate SSH.NET and do what we have done for FTP before. But we need to wait for the next release of SSH.NET for asynchronous IO support.

@hez2010 has this been released yet?

[hez2010]

We can integrate SSH.NET and do what we have done for FTP before. But we need to wait for the next release of SSH.NET for asynchronous IO support.

@hez2010 has this been released yet?

Unfortunately not yet. But I think we can use a custom internal fork.

[BLACK4585]

Is there any progress on this?

[Josh65-2201]

No one has looked into this yet.

[itsWindows11]

I'll try looking into it. Is there a filesystem abstraction and stuff that I should do to properly implement everything as possible? I recall seeing many Win32 specific stuff in the codebase that don't seem to be abstracted away well.

SSH.NET now has async support I think.

cc @yaira2

[wildantea]

yeah, it would nice if sftp is supported. i found this app, for reference
https://apps.microsoft.com/detail/owlfiles-file-manager/9MSQ3SZK42KP?hl=en-us&gl=US
it has supported sftp.

[TimoNotThy]

@itsWindows11 How is this going?

[itsWindows11]

Time constraints on my end slowed down things, plus exams are coming up thus slowing down progress more in the next few weeks. I've got some of the basics ready already for SFTP though, will do a PR by the end of this month.

Sorry for any inconveniences caused here.

[TimoNotThy]

No worries, was just wondering if this was coming along or not

[Arlodotexe]

Files is using an older fork of the SecureFolderFs storage abstraction, which itself was a fork of the OwlCore.Storage project, an early adoption package for the CommunityToolkit.Storage proposal.

I've worked with SecureFolderFS to incorporate their feedback and remove the need to maintain a separate fork, I would suggest we do the same for Files so we aren't duplicating planned work: Arlodotexe/OwlCore.Storage#12, Arlodotexe/OwlCore.Storage#55

[pnoelfr]

It's GOOD ??

sshnet/SSH.NET#1415

[0x5bfa]

From @tmds, @itsWindows11 How do you think?

[itsWindows11]

@0x5bfa
#15477 (comment)

[dedestem]

This will be such an great feature