Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Hide the adaptive layout toggle if it is not available #16698

Closed
Lamparter opened this issue Jan 11, 2025 · 6 comments · Fixed by #16701
Closed

Feature: Hide the adaptive layout toggle if it is not available #16698

Lamparter opened this issue Jan 11, 2025 · 6 comments · Fixed by #16701

Comments

@Lamparter
Copy link
Contributor

Lamparter commented Jan 11, 2025

The adaptive layout toggle should be hidden if it is disabled.

Layout settings

Previous feature request

What feature or improvement do you think would benefit Files?

Currently, if the adaptive layout feature switch is disabled, the user might not be aware that they need to turn off Files settings > Layout > Sync layout and sorting preferences across directories.

Layout settings

An info bar should be added detailing this:

[!NOTE]
The sync layout across directories setting must be disabled to enable adaptive layout.

<InfoBar
    IsOpen="True"
    IsClosable="False"
    Severity="Informational"
    Title="Adaptive layout"
    Message="The sync layout across directories setting must be disabled to enable adaptive layout." />

Requirements

  • Add an info bar control to the layout section if the sync layout across directories setting is disabled
    • Localise the text

Files Version

3.8.11.0

Windows Version

10.0.22631.4602

Comments

Alternative solution: rather than an info bar, it could be a tooltip. This might still confuse the user though as the tooltip isn't as obvious.

I'm unsure whether the info bar should be informational or as a warning.

@Lamparter
Copy link
Contributor Author

Here's an example implementation.

Image

@yaira2
Copy link
Member

yaira2 commented Jan 12, 2025

I would prefer if the option was hidden instead of disabled.

@Lamparter Lamparter changed the title Feature: Add an info bar to the layout settings if the adaptive layout toggle is disabled Feature: Hide the adaptive layout toggle if it is not available Jan 12, 2025
@Josh65-2201
Copy link
Member

I think the infobar would make more sense, since people will know the feature is there and what to do to turn it on. Otherwise to me it will have the same issue as now, people asking where the option is or that it has disappeared randomly.

@yaira2
Copy link
Member

yaira2 commented Jan 12, 2025

There is already a tooltip when the user changes the setting.

@yaira2 yaira2 moved this from 🆕 New to 🏗 In progress in Files task board Jan 12, 2025
@Lamparter
Copy link
Contributor Author

This feature request came from when a member of the Discord server was confused by not being able to change the setting.
Removing the toggle altogether can be seen to defeat the accessibility change, as pointed out by @Josh65-2201
While I agree it is less confusing if the adaptive layout toggle was removed, the info bar is more helpful in the sense that the user would know where to enable the setting again.

@yaira2
Copy link
Member

yaira2 commented Jan 13, 2025

I haven't seen the conversation on Discord, but I'd like to make a couple of points:

  • Without seeing the conversation, I can't say this with certainty, but my assumption is any confusion caused is by having an option displayed that's not available for that context. The same way we hide commands from the context menu and command palette that aren't enabled, we do this for pretty much the rest of the UI (with the main exception being the toolbar). If the option is hidden, this concern is resolved and the user wouldn't even think about it.
  • The sync setting is turned off by default. If a user turns it on, a message is displayed explaining that it doesn't support adaptive mode. As a side point, even without an explanation, syncing the layout implies that it's not going to automatically switch layouts based on the location.
  • It's not clear what the info bar is referring to, it almost looks like an error message. Also, the message isn't very clear and doesn't fully explain how to resolve the issue.
  • To resolve the previous point, we could add a link to settings, but then at that point users would just request an option to directly modify the setting from the flyout, and there will be no end.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Files task board Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants