Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Move settings item into Sidebar footers #16682

Open
marcelwgn opened this issue Jan 7, 2025 · 3 comments
Open

Feature: Move settings item into Sidebar footers #16682

marcelwgn opened this issue Jan 7, 2025 · 3 comments
Assignees
Milestone

Comments

@marcelwgn
Copy link
Contributor

marcelwgn commented Jan 7, 2025

What feature or improvement do you think would benefit Files?

This would align us more with other Windows apps.

Requirements

  • The settings button is part of the footer items of the SideBar

Image

Files Version

N/A

Windows Version

24H2

Comments

No response

@yaira2 yaira2 added this to the Files v4 milestone Jan 7, 2025
@yaira2 yaira2 moved this to 🔖 Ready to build in Files task board Jan 7, 2025
@0x5bfa
Copy link
Member

0x5bfa commented Jan 8, 2025

How far as we going?

  • 1st option (easiest?)
    1. Use LocationItem at the bottom and have a custom logic like IsSettingsButton
    2. Add AnimatedIcon's states in SidebarItem's visual states.
  • 2nd option (This would resolve the 2nd issue below)
    1. Create SidebarGroup (e.g. Pinned, Drives groups, etc) and SidebarItem (e.g. Home, each pinned files, detach drives, etc).
    2. Remove all custom logic for specific scenarios.
    3. Move to Files.App.Controls to isolate from Files.App

#15458
#15283

@marcelwgn
Copy link
Contributor Author

I think an approach similar to the second one would be best where we have a collection of "Footer items" that just gets rendered at the bottom (similar to NavigationView). Moving the control to Files.App.Controls is definitely something we should do.

@0x5bfa
Copy link
Member

0x5bfa commented Jan 10, 2025

Wow, that's really amazing! Depending on LocationItem and SidebarItem having custom implementations for specific scenarios and SidebarView having its own view model (MainPageViewModel should be responsible for it) has been horrible. I'm really looking forward to its mitigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready to build
Development

No branches or pull requests

3 participants