Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add action to open text files in the default text editor #16636

Open
Lamparter opened this issue Dec 21, 2024 · 6 comments
Open

Feature: Add action to open text files in the default text editor #16636

Lamparter opened this issue Dec 21, 2024 · 6 comments

Comments

@Lamparter
Copy link
Contributor

Lamparter commented Dec 21, 2024

What feature or improvement do you think would benefit Files?

A button to the toolbar should be added to open text files (any file detected as containing standard format text) in the default editor - this could either be a setting or just automatically select the default editor for text on the user's computer (the latter is probably better)
This would allow for easy opening of unidentified files and serves as an indicator to the file's contents. It would make it easier to open text files as some programs may register them (e.g. if I want to edit a Visual Studio Solution file it wouldn't be as easy as double clicking as doing so would open it in Visual Studio instead of a text editor).

Requirements

  • Add helper to detect content of files
  • Add action to automatically open file in default text editor

Files Version

3.8.5.0

Windows Version

10.0.22631.4391

Comments

No response

@yaira2
Copy link
Member

yaira2 commented Dec 21, 2024

It sounds like you're requesting to display 'open with' in the toolbar, can you confirm?

@yaira2 yaira2 added the needs - additional info Needs more information from the reporter label Dec 21, 2024
@Lamparter
Copy link
Contributor Author

It sounds like you're requesting to display 'open with' in the toolbar, can you confirm?

Essentially, but it would open with the default text editor in one click rather then a prompt.

@0x5bfa
Copy link
Member

0x5bfa commented Dec 22, 2024

Why not set it as the always open option.

@yaira2
Copy link
Member

yaira2 commented Dec 22, 2024

I can see this being a split button where the main button is 'open' and the drop down section displays the other options.

@Lamparter
Copy link
Contributor Author

Let's discuss this on Discord

My point was mainly about opening text files that would open somewhere else e.g. XAML, C#, SLN or .*proj (all would open in visual studio) inside the default text editor rather than associated app

@yaira2 yaira2 closed this as completed Dec 23, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Files task board Dec 23, 2024
@yaira2 yaira2 changed the title Feature: Add button to toolbar to open text files in chosen editor Feature: Add action to open text files in the default text editor Dec 23, 2024
@yaira2 yaira2 moved this from ✅ Done to 📋 Planning stage in Files task board Dec 23, 2024
@yaira2 yaira2 reopened this Dec 23, 2024
@github-project-automation github-project-automation bot moved this from 📋 Planning stage to 🆕 New in Files task board Dec 23, 2024
@yaira2 yaira2 removed the needs - additional info Needs more information from the reporter label Dec 23, 2024
@yaira2
Copy link
Member

yaira2 commented Dec 23, 2024

After some discussion, we've determined that the underlying use case can be achieved by setting a custom argument for 'open with' (see #15141). However, adding a built-in action can simplify things, ensuring that the action always uses the default text editor, even if the user changes it in the future. In contrast, if the user sets a custom argument, they would have to update it manually.

@yaira2 yaira2 moved this from 🆕 New to 📋 Planning stage in Files task board Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Planning stage
Development

No branches or pull requests

3 participants