-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go packages in protocol/.github #12
Comments
We're currently using a static PR title |
rvagg
added a commit
that referenced
this issue
Aug 20, 2021
@marten-seemann actually yeah, if it's consistently |
rvagg
added a commit
that referenced
this issue
Aug 23, 2021
github-actions bot
pushed a commit
that referenced
this issue
Aug 23, 2021
### [4.0.1](v4.0.0...v4.0.1) (2021-08-23) ### Trivial Changes * make allowance for web3bot 'sync' PRs ([c5b00c8](c5b00c8)), closes [#12](#12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@marten-seemann we have 2 go packages in subdirectories this repo that we could get into the protocol/.github list. One catch is that we now have an auto-tag-and-release for each merged PR in this repo.
It’s not a big deal if we have patch releases triggered by the bot, but we could prevent them by including
[ci skip]
in the commit message.We also use conventional-commits to build changelogs and determine semver bumps for each auto release, so it take the
prefix:
and use that to figure out patch/minor/major. Either likechore:
orfix:
, perhaps with a subsystem,chore(ci):
,fix(ci):
for descriptive changelog entries, would do the trick.Do we have any flexibility in commit messages from the bot, or is that asking too much?
These packages are only for local codegen, not general consumption (at the moment anyway) so it's not a big deal if we leave them out because this is all too hard I think.
The text was updated successfully, but these errors were encountered: