Save output as binary #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because simplecov originally reads the source file as binary https://github.com/colszowka/simplecov/blob/v0.16.1/lib/simplecov/source_file.rb#L94. This Encoding::UndefinedConversionError fguillen#20 is essentially caused by the mismatch of protocols between read and writes. If we always use the template encoding of views/detail.html.erb (UTF-8), it should work for many cases, but such a fix won't work for an encoding which is not compatible with UTF-8. So this patch should be the best fix for this issue.
clucas
approved these changes
Apr 20, 2018
tarhashi
added a commit
to naviplus-asp/simplecov-rcov
that referenced
this pull request
Jul 5, 2018
Save output as binary
|
Any progress on this? |
|
Any word here? This seems like a well-reasoned fix... |
|
Most recent release was in 2011, I think this project is no longer maintained despite still being used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because simplecov originally reads the source file as binary https://github.com/colszowka/simplecov/blob/v0.16.1/lib/simplecov/source_file.rb#L94.
This Encoding::UndefinedConversionError #20 is essentially caused by the mismatch of protocols between read and write.
If we always use the template encoding of views/detail.html.erb (UTF-8), it should work for many cases, but such a fix won't work for an encoding which is not compatible with UTF-8. So this patch should be the best fix for this issue.
Fix #20