Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about need for "DevSender" #42

Open
arggh opened this issue Dec 9, 2017 · 3 comments
Open

Question about need for "DevSender" #42

arggh opened this issue Dec 9, 2017 · 3 comments

Comments

@arggh
Copy link
Contributor

arggh commented Dec 9, 2017

I have been using FiLog with a custom sender when in development mode, "DevSender", which will log to the console, but only produces one line per log event. This way my console doesn't get obfuscated by the 30-50 lines-per-entry log messages.

It's just a minor difference compared to the ConsoleSender, but I was wondering if it's useful or different enough to be added?

@fgm
Copy link
Owner

fgm commented Dec 10, 2017

Sounds interesting: since it's essentially an extension of the ConsoleSender, it looks like it could be merged into it as an option, doesn't it ?

@arggh
Copy link
Contributor Author

arggh commented Dec 10, 2017

Sure, I'll try to work in a PR. Do you have an idea how this option should be specified?

@fgm
Copy link
Owner

fgm commented Dec 10, 2017

Senders take their options in their constructor (look at SyslogSender for an example: https://github.com/FGM/filog/blob/master/src/Senders/SyslogSender.js#L45 ). Just be sure to provide defaults matching the current behavior when no options are passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants