-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Now that "LetsEncryptRenewalService.Certificate" is internal, how do you get the cert for ServerCertificateSelector? #124
Comments
You simply shouldn't have to. That step is no longer required. |
Does this mean that if I still call private static void ConfigureWebHostForHttpAndHttps(IWebHostBuilder webHostBuilder, StandardConfiguration standardConfiguration)
{
webHostBuilder.UseUrls($"http://0.0.0.0:{standardConfiguration.Http.HttpPort}", $"https://0.0.0.0:{standardConfiguration.Http.HttpsPort}");
webHostBuilder.UseKestrel(kestrelOptions =>
kestrelOptions.ConfigureHttpsDefaults(httpsOptions =>
{
httpsOptions.SslProtocols = sslProtocols;
httpsOptions.OnAuthenticate = SslOptionConfigurer;
}));
} |
Yes, fairly certain about that 👍 let me know how it goes. |
This document from Microsoft seems related: https://learn.microsoft.com/en-us/aspnet/core/fundamentals/servers/kestrel/endpoints?view=aspnetcore-8.0 It also says:
|
…Net.EncryptWeMust The library we use for LetsEncrypt invokes 'ConfigureHttpsDefaults' at https://github.com/ffMathy/FluffySpoon.AspNet.EncryptWeMust/blob/6f6ac68cad178abadb5838edc8b29274d72d3519/src/FluffySpoon.AspNet.EncryptWeMust/KestrelOptionsSetup.cs#L22-L25 Also see <https://learn.microsoft.com/en-us/aspnet/core/fundamentals/servers/kestrel/endpoints?view=aspnetcore-8.0> An excerpt from the documentation from Microsoft: > Calling ConfigureHttpsDefaults multiple times replaces prior Action instances with the last Action specified. Related discussion at <ffMathy/FluffySpoon.AspNet.EncryptWeMust#124 (comment)>
I have the following code running an older version of what was then called LetsEncrypt:
I want to update to a newer version of EncryptWeMust, however the above
Certificate
onLetsEncryptRenewalService
was marked as internal in this commit.How do I fetch the certificate now?
Edit: I suppose I could be naughty and get it with reflection, but I'd rather do it the right way.
The text was updated successfully, but these errors were encountered: