Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parmmg: add new versions up to 1.5 and new variants #47387

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

parmmg: add new versions up to 1.5 and new variants #47387

wants to merge 5 commits into from
+132 −2

Conversation

prudhomm
Copy link
Contributor

@prudhomm prudhomm commented Nov 3, 2024 •
edited
Loading

variant vtk: make vtk optional
variant shared: build shared libs

added patch to fix parmmg cmake so that it can be used by other software with find_package

the PR depends on PR #47386

@prudhomm
add new versions up to 1.5 and new variants
e975f9d 
variant vtk: make vtk optional
variant shared: build shared libs

added patch to fix parmmg cmake so that it can be used by other software with find_package
@prudhomm
use +private for [email protected]: and [email protected]:
64c4f75
@spackbot-app spackbot-app bot requested a review from corentin-dev November 3, 2024 15:33
@prudhomm
Copy link
Contributor Author

prudhomm commented Nov 3, 2024

The patch has been submitted to upstream MmgTools/ParMmg#137

@corentin-dev
Copy link
Contributor

corentin-dev commented Nov 4, 2024 •
edited
Loading

Is the patch working on each declared version of parmmg? Maybe it is better to specify the version using (for example):

    patch(
        "parmmg_cmake_patch.diff",
        when="@:1.5.0",
        sha256="b6002dc32372b7d78ed5b16e0932ab12049d1dbec5f6389403603af450fd818d",
    )

@corentin-dev
Copy link
Contributor

There is a missing variant in mmg:

1. parmmg: wrong variant used for dependency in 'depends_on()'
    No such variant 'private' in package mmg

@prudhomm
Copy link
Contributor Author

There is a missing variant in mmg:

1. parmmg: wrong variant used for dependency in 'depends_on()'
    No such variant 'private' in package mmg

this is implemented in #47386

@prudhomm
Copy link
Contributor Author

@corentin-dev I implemented the fixes. However it depends on PR #47386 to support +private_headers so that parmmg can compile.
that's why the CI currently fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corentin-dev corentin-dev Awaiting requested review from corentin-dev

At least 1 approving review is required to merge this pull request.

Assignees

@corentin-dev corentin-dev

Labels
dependencies new-variant new-version patch update-package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parmmg: new version and new variants
2 participants
@prudhomm @corentin-dev