Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add python-json5 to support comments in json python parser #9

Open
prudhomm opened this issue Jul 7, 2022 · 1 comment
Open

add python-json5 to support comments in json python parser #9

prudhomm opened this issue Jul 7, 2022 · 1 comment
Assignees
@prudhomm @thomas-saigre
Labels
enhancement New feature or request

Comments

@prudhomm
Copy link
Member

prudhomm commented Jul 7, 2022

python json5 package allows comments in json files
this can be used as a replacement of json
@prudhomm prudhomm added the enhancement New feature or request label Jul 7, 2022
@prudhomm prudhomm added this to Feel++ Jul 7, 2022
prudhomm added a commit that referenced this issue Jul 7, 2022
@prudhomm
add python-json5 to support comments in json python parser fixes #9
aeea7c2
@thomas-saigre
Copy link
Collaborator

@prudhomm I think this issue has been fixed. Moreover, I modified the function __init__.py.in (see feelpp/feelpp@1573e7e) so we don't need to use json5 anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prudhomm prudhomm

@thomas-saigre thomas-saigre

Labels
enhancement New feature or request
Projects
Feel++
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prudhomm @thomas-saigre