Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a custom 404 page #176

Closed
gridhead opened this issue Sep 29, 2021 · 11 comments
Closed

Create a custom 404 page #176

gridhead opened this issue Sep 29, 2021 · 11 comments
Assignees
Labels
fragment A functional rewrite of the project frontend Frontend development good first issue Good for newcomers hacktoberfest Contribute here to get a free tee help wanted Anyone is welcome to help us with this!

Comments

@gridhead
Copy link
Member

Create a custom 404 page

@gridhead gridhead added help wanted Anyone is welcome to help us with this! good first issue Good for newcomers fragment A functional rewrite of the project frontend Frontend development labels Sep 29, 2021
@siddhantkhariwal
Copy link

Hey, Can I fix this issue?

@gridhead
Copy link
Member Author

@siddhantkhariwal,

I'd suggest completing #170 first before moving on to working on this.

@gridhead gridhead added the hacktoberfest Contribute here to get a free tee label Sep 30, 2021
@jaehoonhwang
Copy link
Contributor

Mind if I work on this?

@gridhead
Copy link
Member Author

gridhead commented Oct 4, 2021

Sure, @jaehoonhwang. I'm assigning you this issue.

@jaehoonhwang
Copy link
Contributor

Checking in for custom 404; does this look fine?

image

@jaehoonhwang
Copy link
Contributor

Try #2
image

@gridhead
Copy link
Member Author

gridhead commented Oct 4, 2021

The vector image that you have made use of in here #176 (comment). Could you please state its source and license of usage?

@jaehoonhwang
Copy link
Contributor

@t0xic0der

It doesn't have a dedicated page for the image;
site -> search 404

License on site: License

@gridhead
Copy link
Member Author

gridhead commented Oct 4, 2021

I see.

Could you please set the palette color to #80C0C0 in https://undraw.co/search and use the fourth image? (The one with leaves)

image

Regarding the legality of the usage of the image, I'd tag @jwflory here as he would probably have a better context on this.

@jaehoonhwang
Copy link
Contributor

jaehoonhwang commented Oct 4, 2021

Done;

Also, edited out the button and just replace with the hex value you wanted.

image

@gridhead
Copy link
Member Author

@jaehoonhwang, thank you for your PR.

Closing this via #191.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fragment A functional rewrite of the project frontend Frontend development good first issue Good for newcomers hacktoberfest Contribute here to get a free tee help wanted Anyone is welcome to help us with this!
Projects
None yet
Development

No branches or pull requests

3 participants