setup_logger to use config.log_level for basicConfig #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason ctranslate2 4.3.0 doesn't work anymore
Now users will also have to specify a full model name. Before: tiny.en Now: Systran/faster-whisper-tiny.en
Notable change is that whisper model won't be loaded on startup anymore
usefull -> useful
Fixed mistakes and typos
patches the faster_whisper_serve.logger#setup_logger to use config.log_level to setup the basic config. also clears unnecessary initialisations of logger (as we are not returning any logger from the method) afaik, the logger created, with logging.getLogger, falls back to the root logger's handlers if no handler is specified for the created logger itself. If need be, the `logging.root.handler.clear()` method could be used to clear all pre initialized handlers on the logger before (re)setting it.
|
@fedirz a gentle ping. |
fedirz
force-pushed
the
master
branch
3 times, most recently
from
e47fdeb to
196f56a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patches
faster_whisper_serve.logger#setup_loggerto useconfig.log_levelto setup thelogger.basicConfig. also clears unnecessary initialisations of logger since we are not returning any logger from the methodafaik, the logger created, with logging.getLogger, falls back to the root logger's handlers if no handler is specified for the created logger itself.
If need be, the
logging.root.handler.clear()method could be used to clear all pre initialized handlers on the logger before (re)setting it.while i was not able to reproduce the error; this patch should ideally fix #114