Show existing linked report in F24 IE

[exalate-issue-sync]

Business Reason

As a user, when I have a Independent Expenditure MEMO with dates oustide of my Form 3X report, I would like the linked report to be used when linking the memo (tier 2) transaction to a Form 24, so that I can accurately report and track my Independent Expenditures in my Form 24.

Task: Update F24 IE form to use linked report as source of truth for “Linked report” for existing IEs rather than checking dates. Behavior stays the same for new F24 IEs.

Acceptance criteria

Given an Independent Expenditure memo ( Tier 1 or Tier 2) in a Form 3X with dates outside of the Form 3X report dates

When I link a Tier 1 IE with a Form 24 report

And the related memo is linked in that process (See https://fecgov.atlassian.net/browse/FECFILE-1767 for details on this)

Or when I link a Tier 1 memo with a Form 24 report

Then when I view the transaction(s) in Form 24 report the ‘Linked report’ for each IE transaction will display the Form 3X where the transaction is linked

QA Notes

null

DEV Notes

Background

Currently, the “Linked report” field in an F24 IE shows whatever report contains the disbursement or dissemination date (specific rules defined in [https://fecgov.atlassian.net/issues/FECFILE-528?jql=textfields%20~%20%22%5C%22linked%20report%5C%22%22%20AND%20project%20%3D%20FECFILE|https://fecgov.atlassian.net/issues/FECFILE-528?jql=textfields%20~%20%22%5C%22linked%20report%5C%22%22%20AND%20project%20%3D%20FECFILE|smart-link] ). This makes sense for creating a new IE in a F24. For an existing F24 IE, we can actually refer to the report id stored in the transaction as our source of truth. Most often this will produce the same outcome. For memo item IE’s created in an F3X, outside of that F3X’s report coverage dates, using the dates will cause an undesired state while referring to the already linked report will show correctly.

Example of where using only the dates can go wrong:

Create memo item IE in F3X outside of coverage dates

Form 3X report coverage dates: 01/01/2025 - 01/31/2025

Memo Dissemination Date: 02/01/2025

Add the IE to an F24 - Select ‘Add to Form24 Report’ from the Action dropdown

Open that IE in the F24. Because our current design is to show whatever report contains the date, rather than refer to the actual linked report, we find no report. Instead, we want to refer to the actual linked report because this is an existing transaction. (NOTE: if in step 1, you set the dates to be within a different report’s coverage dates, that report would show up in “Linked report” even if it’s not linked)

Linked report will be blank with an error message

Design

See full ticket and images here: FECFILE-1904

[exalate-issue-sync]

akhorsand commented: Problem #1: if a MEMO IE is created in an F3X with dates outside the coverage dates, then added to a Form 24, it can show an incorrect linked 3X if the date falls in coverage dates in another existing Form 3X (or none at all if one does not exist). Proposed solution: In the linked report field, show report that it is linked to. If it is not linked, link based on date entered. Note even if linked report already exists, the user can technically change the linked report if they change the date, memo or not.

Problem #2 (separate ticket): Users can change what Form 3X report an IE is in by changing the date from the Form 24. Is this ok? If not, needs to locked down.

[exalate-issue-sync]

gregg.moreland commented: [~accountid:61b0b42cd5986c006a9e1c94] I think for Problem #2, we should probably allow that functionality to stay in place until we have the full solution for changing report dates, and even then, we might need to be able to change which Form 3X if the dates on the Form 3x change.

[exalate-issue-sync]

Todd Lees commented: [~accountid:712020:3243085d-540a-4657-ad08-d891487882d0] agreed

[exalate-issue-sync]

gregg.moreland commented: [~accountid:61b0b42cd5986c006a9e1c94] [~accountid:712020:2a1493e5-adee-45bd-b27e-868a5c8d3f62] I updated this with the AC’s; I moved all of the detail that Todd put in here to the Dev notes (but removed the images since images don’t work correctly in Exalate, so I just described what was in the images)

[exalate-issue-sync]

gregg.moreland commented: [~accountid:712020:2a1493e5-adee-45bd-b27e-868a5c8d3f62] I’ve updated this to account for tier 1 memos, as well as try to state that all IE’s linked from Form 3X will have the correct ‘linked report’ value