API tests fail after 9pm

[exalate-issue-sync]

Update API to address failing f1m unit tests that run after 9pm. Either:

• Fix bug identified by unit test

or

• Fix unit test to run correctly after 9pm

Identify a way to reproduce this during normal working hours

Most likely related to time zones

https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/4585/workflows/3e8a4ac1-7737-4520-ae4f-a40516d8f9ad/jobs/13205

======================================================================
FAIL: test_date_signed (fecfiler.web_services.dot_fec.tests.dot_fec_record_testing.test_form_f1m.DotFECForm1MTestCase)

Traceback (most recent call last):
File "/home/circleci/project/django-backend/fecfiler/web_services/dot_fec/tests/dot_fec_record_testing/test_form_f1m.py", line 261, in test_date_signed
self.assertEqual(self.split_row[70], formatted_date)
AssertionError: '20241120' != '20241119'

• 20241120
  ? ^^

• 20241119
  ? ^^

QA Notes

null

DEV Notes

Oddly, switching to {{self.today = datetime.now(timezone.utc)}} in both {{test_form_f1m.py}} and {{test_schedule_e.py}} resulted in my tests failing locally:

{noformat}======================================================================
FAIL: test_date_signed (fecfiler.web_services.dot_fec.tests.dot_fec_record_testing.test_schedule_e.DotFECScheduleETestCase)

Traceback (most recent call last):
File "/opt/nxg_fec/fecfiler/web_services/dot_fec/tests/dot_fec_record_testing/test_schedule_e.py", line 210, in test_date_signed
self.assertEqual(self.split_row[41], formatted_date)
AssertionError: '20241119' != '20241120'

• 20241119
  ? ^^

• 20241120
  ? ^^
  {noformat}

Design

null

See full ticket and images here: FECFILE-1822

[exalate-issue-sync]

Laura Beaufort commented: [~accountid:712020:eaccd25d-427c-4e4d-a650-909ec0b31071] and [~accountid:712020:2a1493e5-adee-45bd-b27e-868a5c8d3f62] - FYI, I merged Elaine’s PR and set up a scheduled build for 10pm tonight. I’ll make sure it passes and then pass the ticket to QA.

[exalate-issue-sync]

Laura Beaufort commented: [~accountid:712020:169a1b29-e3ab-43ca-a22d-7d6f230207bd] for QA - the tests passed at 10pm at 11/27:

[https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/4633/workflows/91efda85-7fe1-41f6-8e9a-4ca4db92c35a/jobs/13281|https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/4633/workflows/91efda85-7fe1-41f6-8e9a-4ca4db92c35a/jobs/13281]

!Screenshot 2024-11-29 at 11.27.39 AM.png|width=1233,height=354,alt="Screenshot 2024-11-29 at 11.27.39 AM.png"!

[exalate-issue-sync]

Shelly Wise commented: QA review verified Unit Tests passed at 10pm at 11/27 as denoted in this ticket.

!image-20241204-131142.png|width=1290,height=520,alt="image-20241204-131142.png"!

Moved to Stage Ready.