Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class warnings #1206

Open
exalate-issue-sync bot opened this issue Nov 14, 2024 · 2 comments
Open

Fix class warnings #1206

exalate-issue-sync bot opened this issue Nov 14, 2024 · 2 comments
Assignees

Comments

@exalate-issue-sync
Copy link

exalate-issue-sync bot commented Nov 14, 2024

Make changes to class definitions to address warnings.

  • Rename fecfiler.reports.serializers.Form3XSerializer to ReportForm3XSerializer it is only used within the Report serializer
  • Ensure that errors do not occur after https://fecgov.atlassian.net/browse/FECFILE-1671 for authentication views authenticate_logout and authenticate_login

We identified these issues from the following warnings about our classes in the api:

{{/home/vcap/app/django-backend/fecfiler/authentication/views.py: Error [authenticate_logout]: unable to guess serializer. This is graceful fallback handling for APIViews. Consider using GenericAPIView as view base class, if view is under your control. Either way you may want to add a serializer_class (or method). Ignoring view for now. }}

Nov 14, 2024 @ 09:42:48.752 APP INFO /home/vcap/app/django-backend/fecfiler/devops/views.py: Error [SystemStatusViewSet]: unable to guess serializer. This is graceful fallback handling for APIViews. Consider using GenericAPIView as view base class, if view is under your control. Either way you may want to add a serializer_class (or method). Ignoring view for now.

Nov 14, 2024 @ 09:42:48.746 APP INFO /home/vcap/app/django-backend/fecfiler/authentication/views.py: Error [authenticate_login]: unable to guess serializer. This is graceful fallback handling for APIViews. Consider using GenericAPIView as view base class, if view is under your control. Either way you may want to add a serializer_class (or method). Ignoring view for now.

Nov 14, 2024 @ 09:42:48.656 APP INFO /home/vcap/app/django-backend/fecfiler/reports/form_3x/serializers.py: Warning [Form3XViewSet > Form3XSerializer]: Encountered 2 components with identical names "Form3X" and different classes and . This will very likely result in an incorrect schema. Try renaming one.

QA Notes

Unit tests will pass

DEV Notes

null

Design

null

See full ticket and images here: FECFILE-1787

Copy link
Author

Copy link
Author

Shelly Wise commented: QA review verified Unit Tests passing per DEV.

!image-20241204-131534.png|width=1283,height=470,alt="image-20241204-131534.png"!

Moved to Stage Ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants