Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Score mean display incorrect #901

Open
w3333 opened this issue Oct 22, 2021 · 4 comments
Open

Score mean display incorrect #901

w3333 opened this issue Oct 22, 2021 · 4 comments

Comments

@w3333
Copy link

w3333 commented Oct 22, 2021

Hi,

I presume the setting for score mean with/without komi is reversed. When I set it to "score mean" without komi, I expect a score estimate of around 6.5 on the empty board. When set to "score mean + komi" it should be around 0, right? It is exactly the other way around, see screenshots. If I misunderstand please apologize. But it is rather confusing this way.

Bildschirmfoto vom 2021-10-22 20-27-32
Bildschirmfoto vom 2021-10-22 20-25-50

@kaorahi
Copy link
Contributor

kaorahi commented Oct 23, 2021

KataGo's "ScoreMean" is defined as the score with komi. So "+Komi" intends "cancel komi" actually. :(

I agree that these labels are confusing for most users. I have two options.

  • (A) Rename them to "Score with Komi" and "Score without Komi".
  • (B) Simply swap their behaviors.

But I am hesitating because...

  • (A) causes inconsistency with other supported languages.
  • (B) looks wrong for those who know KataGo well.

(Note for programmers: See git grep showKataGoBoardScoreMean.)

@w3333
Copy link
Author

w3333 commented Oct 23, 2021

Ok. That's weird but of course that happens. And how about making the label depending on the engine? Weird too? I don't know. Someone will always be confused I guess. I finally figured this out after 3 years... so now I can live with it either way. Just seems a bit suboptimal the way it is now. I think most people will want to see the score with komi. Why wouldn't you... so that should be what you see by default, regardless of the engine. Only some special use case will need the score without komi. Which could be some checkbox in settings?

Anyway. It's up to you of course. I'm already happy you agree that it is confusing :)

@killerducky
Copy link

I suggest removing the score without komi function. Keep it simple.

@w3333
Copy link
Author

w3333 commented Oct 24, 2021

Another possibility might be to remove the "without komi" option completely, like @killerducky suggests, and display the komi somewhere prominent in the score graph, so that it is clear on first sight what the numbers mean. Then it would be (supposedly) clear that all score estimates are including komi (using kata), and whether that is 6.5, 5.5, 0.5 or something else would be visible all the time (which would be nice anyway since it's a vital game info). I don't know about leelaz, but if you see the score values and the komi together, on the empty board it should be clear to everbody whether the scoremean includes komi or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants