Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for hexadecimal string in constructor #37

Open
prateekroy opened this issue Oct 23, 2018 · 9 comments · May be fixed by #47
Open

Add support for hexadecimal string in constructor #37

prateekroy opened this issue Oct 23, 2018 · 9 comments · May be fixed by #47
Labels
enhancement New feature or request priority: low Low priority

Comments

@prateekroy
Copy link

I think it will be useful for the BigInt to take hex as input and represent it as BigInt and support all the operations? Let me know what you think of it and I can start working on it.
@faheel
Copy link
Owner

faheel commented Oct 28, 2018

@prateekroy I don't see how it would be useful. Can you give a few examples?

@prateekroy
Copy link
Author

@faheel I was thinking of something like this BigInt("0xFFABFF") and support all the operations for this BigInt.

BigInt("0xA") + BigInt("1") = "0xB".

@faheel faheel mentioned this issue Jun 1, 2019
Closed
@faheel faheel changed the title Should there be an constructor for taking hex as input? Add support for hexadecimal string in constructor Jun 1, 2019
@faheel faheel added enhancement New feature or request priority: low Low priority labels Jun 1, 2019
@faheel
Copy link
Owner

faheel commented Jun 1, 2019

@prateekroy Seems like a useful feature to have for some use cases.

If anyone's interested in taking up this issue then feel free to create a PR

@EndrII
Copy link

EndrII commented Jun 4, 2019

When to expect this feature?

@waegemans waegemans linked a pull request Jul 7, 2019 that will close this issue
Open
@Rucadi
Copy link

Rucadi commented Mar 22, 2020

I would like to have a feature to read a byte array into a BigNum, I'm using this library to get big num data from a server.
If I end up doing it myself, but It could be nice to have it in the library.

@EndrII
Copy link

EndrII commented Mar 23, 2020

i recomendet use gmp wraper for C++
https://github.com/QuasarApp/QtBigInt

@faheel
Copy link
Owner

faheel commented Oct 5, 2020

Sorry for the long delay in looking into this feature. Looks like multiple people are interested in it, so I'll take a look at the PR once I get more time.

@cwsimms-98
Copy link

Hey is it ok if I look into this feature?

@touatily
Copy link

touatily commented Jan 3, 2024

Handling many bases is better in my opinion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority: low Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

construction from hex strings waegemans/BigInt
6 participants
@Rucadi @faheel @EndrII @prateekroy @touatily @cwsimms-98