Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create leapfrogs for two mods retouring into the same functions. #1

Open
notnotmelon opened this issue Aug 12, 2024 · 0 comments
Open

Comments

@notnotmelon
Copy link
Member

Whenever a function is detoured into, it has the ability to edit the arguments and return type.
However if a second mod detours into the same function, which return type should we use? It's ambiguous.

The solution is to leapfrog the detours.
Instead of mod A and mod B both detouring to the same function, mod B instead detours into the rust function provided by mod A.

Ex:

ModB(ModA(LuaSurface::valid(self)))) -> bool

@notnotmelon notnotmelon converted this from a draft issue Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant