From 7e799c7337e4287d7fe19180b29a02f396ebdfdc Mon Sep 17 00:00:00 2001 From: Heinrich Kuttler Date: Wed, 16 Jun 2021 11:49:39 +0200 Subject: [PATCH] Remove seeds from internal observation, add warning. Unfortunately, xwaitforspace is in internal currently and it is somewhat useful when auto-skipping of messages isn't turned on. --- nle/env/base.py | 6 ++++++ version.txt | 2 +- win/rl/winrl.cc | 4 ++-- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/nle/env/base.py b/nle/env/base.py index 2b849b0b6..67eed3609 100644 --- a/nle/env/base.py +++ b/nle/env/base.py @@ -282,6 +282,12 @@ def __init__( self._observation_keys = list(observation_keys) + if "internal" in self._observation_keys: + logger.warn( + """The 'internal' NLE observation was requested. +This might contain data that shouldn't be abailable to agents.""" + ) + # Observations we always need. for key in ( "glyphs", diff --git a/version.txt b/version.txt index faef31a43..39e898a4f 100644 --- a/version.txt +++ b/version.txt @@ -1 +1 @@ -0.7.0 +0.7.1 diff --git a/win/rl/winrl.cc b/win/rl/winrl.cc index 32d2d581d..5452de5da 100644 --- a/win/rl/winrl.cc +++ b/win/rl/winrl.cc @@ -252,8 +252,8 @@ NetHackRL::fill_obs(nle_obs *obs) obs->internal[2] = in_getlin; obs->internal[3] = xwaitingforspace; obs->internal[4] = stairs_down; - obs->internal[5] = nle_seeds[0]; /* core */ - obs->internal[6] = nle_seeds[1]; /* disp */ + obs->internal[5] = 0; /* used to be core seed */ + obs->internal[6] = 0; /* used to be disp seed */ obs->internal[7] = u.uhunger; obs->internal[8] = u.urexp; /* score (careful! check botl_score() and end.c) */