build(cmake): Add VELOX_BUILD_FUZZERS option #10802
Conversation
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
| @@ -461,8 +461,13 @@ add_compile_definitions(FOLLY_HAVE_INT128_T=1) | |||
| set_source(folly) | |||
| resolve_dependency(folly) | |||
|
|
|||
| if(${VELOX_BUILD_TESTING}) | |||
| # Spark qury runner depends on absl, gRPC. | |||
| if(VELOX_BUILD_FUZZERS) | |||
There was a problem hiding this comment.
Is the fuzzer considered part of testing? Wondering if it makes sense to check both VELOX_BUILD_TESTING and VELOX_BUILD_FUZZERS. Thanks.
There was a problem hiding this comment.
My thinking is that fuzzers and unit tests should be independent.
VELOX_BUILD_TESTING should enable/disable unit tests.
VELOX_BUILD_FUZZERS should enable/disable fuzzers.
There was a problem hiding this comment.
While we might build fuzzers when we also build testing it does make sense to make them independent, would save us build time in the fuzzer builds and test builds respectivly.
|
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions! |
majetideepak
changed the title
Fixes: #11797