From b42a00c004ca483936403cec0d65032a3d97562a Mon Sep 17 00:00:00 2001 From: "Genevieve (Genna) Helsel" Date: Fri, 3 Jan 2025 09:58:54 -0800 Subject: [PATCH] fix FinishedMount::populate() to log backing_store_type Summary: This field was added to `FinishedMount` but never added to `populate()`. This diff fixes this so we log the `backing_store_type` to scuba. The motivation behind sending this diff was that I tried to use this data before (to see the distribution of types) and it was missing. Reviewed By: jdelliot Differential Revision: D67767064 fbshipit-source-id: 6cc9e4d3872f0d2adf04f15f8edf1c9aac078264 --- eden/fs/telemetry/LogEvent.h | 1 + 1 file changed, 1 insertion(+) diff --git a/eden/fs/telemetry/LogEvent.h b/eden/fs/telemetry/LogEvent.h index 07db6755129dd..74c4ac045c6c5 100644 --- a/eden/fs/telemetry/LogEvent.h +++ b/eden/fs/telemetry/LogEvent.h @@ -294,6 +294,7 @@ struct FinishedMount : public EdenFSEvent { inode_catalog_type(inode_catalog_type) {} void populate(DynamicEvent& event) const override { + event.addString("backing_store_type", backing_store_type); event.addString("repo_type", repo_type); event.addString("repo_source", repo_source); event.addString("fs_channel_type", fs_channel_type);