Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add crypto create(De)cipher options parameter #8084

Closed
wants to merge 1 commit into from
Closed

Add crypto create(De)cipher options parameter #8084

wants to merge 1 commit into from

Conversation

skeggse
Copy link
Contributor

@skeggse skeggse commented Sep 16, 2019 •
edited
Loading

See crypto.createCipher, crypto.createCipheriv, crypto.createDecipher and crypto.createDecipheriv documentation. These functions supported a duplexStreamOption as recently as Node 8, and supported an additional authTagLength as recently as Node 10.

Another approach could use overloading to avoid unexpected issues with ivs being null when the algorithm needs an IV.

@goodmind goodmind added the Library definitions Issues or pull requests about core library definitions label Sep 16, 2019
@goodmind
Copy link
Contributor

goodmind commented Sep 17, 2019 •
edited
Loading

I rather have this merged #7676 before this

@goodmind goodmind added the node label Sep 17, 2019
@skeggse
Copy link
Contributor Author

skeggse commented Oct 15, 2020

Closing in favor of #7676.

@skeggse skeggse closed this Oct 15, 2020
@skeggse skeggse deleted the patch-1 branch October 15, 2020 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Library definitions Issues or pull requests about core library definitions node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skeggse @goodmind @facebook-github-bot