New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handlers #83

Open

3 tasks

AlexandraOM opened this issue Dec 13, 2019 · 0 comments

AlexandraOM commented Dec 13, 2019

It's been a really ambitious project and you guys have done really well to make it work 🎉

You can see how many moving parts there are by the number of handlers you have.

You don't seem to use your handleSelect function - what would it used for?
Are you able to make them neater by either trying

promises
reusing the same handler
giving more obvious names - what do handleA and handleD do and can they be handled inside handlers.js rather than in router.js??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment