Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

router.js enhancement #41

Open
LaLeonie opened this issue Dec 6, 2019 · 1 comment
Open

router.js enhancement #41

LaLeonie opened this issue Dec 6, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@LaLeonie
Copy link

LaLeonie commented Dec 6, 2019

This is a minor issue. Just be aware that in your router.js, you should be as specific as possible in your if conditions. So instead of

endpoint.includes("/public")

it would be more specific to use

endpoinr.startsWith("/public")

This way, there won't be any conflicts if you add an endpoint later on which includes the word public
@LaLeonie LaLeonie added the enhancement New feature or request label Dec 6, 2019
@renatadev
Copy link
Member

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@renatadev @LaLeonie