Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Java version #2

Open
fabiencelier opened this issue Oct 28, 2019 · 4 comments
Open

Support Java version #2

fabiencelier opened this issue Oct 28, 2019 · 4 comments
Assignees
@Kineolyan
Labels
✨ new tool Support for new a tool or language

Comments

@fabiencelier
Copy link
Owner

Support for Java, probably something similar to that SO post

Add test cases, this probably require a test framework too
@fabiencelier fabiencelier added the ✨ new tool Support for new a tool or language label Oct 28, 2019
@fabiencelier fabiencelier self-assigned this Oct 28, 2019
@fabiencelier
Copy link
Owner Author

There is basic support but I'd like to improve it a bit to support more edge cases

@Kineolyan
Copy link
Contributor

Can you list the edge cases you want to support?
You could start a branch with the test cases, if you want someone - me? - to pick up the implementation 😄

@Kineolyan
Copy link
Contributor

I'll work on this, as I already looked at it some time ago.

@fabiencelier
Copy link
Owner Author

There is one invalid test with JAVA_6 you can look at

@Kineolyan Kineolyan mentioned this issue Nov 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kineolyan Kineolyan

Labels
✨ new tool Support for new a tool or language
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct the parsing of Java version. Kineolyan/universions
2 participants
@Kineolyan @fabiencelier