Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with PDF and TXT extensions #195

Open
ganiserb opened this issue Jun 1, 2021 · 1 comment
Open

Problem with PDF and TXT extensions #195

ganiserb opened this issue Jun 1, 2021 · 1 comment

Comments

@ganiserb
Copy link

ganiserb commented Jun 1, 2021

Hello, I've noticed that .txt and .pdf ending strings do not show any icon in the sample page (not even the default icon): https://exuanbo.xyz/file-icons-js/

At first I thought it was a problem with my project, but then I realized it's the only icon that has a different class name than the others:

https://github.com/exuanbo/file-icons-js/blob/master/lib/icons/.icondb.js#L1391

https://github.com/exuanbo/file-icons-js/blob/master/lib/icons/.icondb.js#L1690-L1702

If I have some time I will make a PR to fix it using Font Awesome icons.

@ganiserb
Copy link
Author

Update, because it's getting buried. A solution can be found in this other pull request #204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant