Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evil-smartparens overrides "o" in visual state #48

Open
TheBB opened this issue Apr 3, 2018 · 2 comments
Open

Evil-smartparens overrides "o" in visual state #48

TheBB opened this issue Apr 3, 2018 · 2 comments

Comments

@TheBB
Copy link

TheBB commented Apr 3, 2018

I don't know about you, but I consider this to be a bit of an issue, I use the default meaning of "o" fairly frequently. Please consider using another key for this.

Moreover, the binding is added in evil-sp--add-bindings, a function that whenever the mode is enabled (in every buffer). That shouldn't be necessary, the bindings should only have to be made once. The upshot of this is that I can't simply unbind the key once, either, I need to use a hook or an advise to do it, which is a little awkward. If you don't want to move the binding I'd appreciate if it was a little easier to change it.

@expez
Copy link
Owner

expez commented Apr 4, 2018

Makes sense.

What does o do? I'm pretty sure this binding wasn't available in evil when I wrote this package. At least I hope not!

I'll add this to my list, but I don't have much time for OSS lately unfortunately. In other words, I'd love a PR ;)

@TheBB
Copy link
Author

TheBB commented Apr 5, 2018

I'll give it a shot.

It moves the cursor between the two ends of the region, e.g. you could press v, hold l to expand the region to the right, then press o and hold h to expand it to the left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants