Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review implementation of DuplicateCheckerPlugin #66

Closed
pc9795 opened this issue Nov 30, 2021 · 2 comments
Closed

Review implementation of DuplicateCheckerPlugin #66

pc9795 opened this issue Nov 30, 2021 · 2 comments

Comments

@pc9795
Copy link
Collaborator

pc9795 commented Nov 30, 2021

It looks like the use of the hashes list in the plugin is buggy. Have to review the implemenation
@niemyjski
Copy link
Member

niemyjski commented Nov 30, 2021 •
edited
Loading

Might also be worth having some test coverage for event hashes / known model hashes.

@pc9795
Copy link
Collaborator Author

pc9795 commented Nov 18, 2023

Closing as WAD

@pc9795 pc9795 closed this as completed Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niemyjski @pc9795