Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cancelling registrations by organisers #67

Open
matthijskooijman opened this issue Nov 19, 2019 · 2 comments
Open

Allow cancelling registrations by organisers #67

matthijskooijman opened this issue Nov 19, 2019 · 2 comments

Comments

@matthijskooijman
Copy link
Member

When cancelling, the full status should be adapted according to #9 (comment). This can probably be done in the Registration.save method.

Initially, registrations can only be cancelled by organizers through the admin.

@matthijskooijman
Copy link
Member Author

One thing to keep in mind is that when a registration is cancelled, the amount of payment refunded might vary. The current implementation does not treat CANCELLED specially, so this means Arta assumes the full price is owed on cancellation still. In practice, all or a part of the price will be refunded. This probably needs some way to add additional entries to the priced option list, unique for this registration (unlike regular priced options, which are linked to the event). A simple way to do this is to just add a "Extra price" and "Extra price description" to the registration, which can then be used for cancellations but also other price exceptions for active registrations (though things become a bit more cloudy when you'd need both).

Since the originally selected options should IMHO remain selected, this means that either the extra price for a cancelled registration should be negative (i.e. show how much will be refunded), or cancelled registrations should have their regular price set to zero and only apply the extra price. Not sure which is better yet, though.

matthijskooijman added a commit that referenced this issue Nov 3, 2021
In practice, a part of the price might still be owed, but this should be
independently stored elsewhere later (this is part of #67), the original
price should no longer matter.

This also changes payment_status so that registrations with payments are
never considered free, since these can now be cancelled registrations
that still need to be refunded.
@matthijskooijman
Copy link
Member Author

Since the originally selected options should IMHO remain selected, this means that either the extra price for a cancelled registration should be negative (i.e. show how much will be refunded), or cancelled registrations should have their regular price set to zero and only apply the extra price. Not sure which is better yet, though.

The latter is now implemented.

In commit 3ef5c07 some logic was implemented to give cancelled registrations a zero price, since that is the common case with our current policies. Then in 2f2d05a, price corrections were implemented, which can be used to add one-off price corrections to active registrations, or be used to add a cancellation fee, giving full control to the organizer to set the cancellation costs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant