Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support type qualifiers in type arguments #462

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sergeshustoff
Copy link
Contributor

@sergeshustoff sergeshustoff commented Jan 10, 2025

Added support for qualifiers in genric arguments.

Closes #409

@sergeshustoff
Copy link
Contributor Author

One of the problems is that type qualifier, even directly on returned type, doesn't always mean exactly the same thing as qualifier on provider function/property for @IntoSet and @IntoMap. Because of that I had to keep function/property qualifier separate from resulting qualifier in TypeKey, but merge them together with type qualifier for equals check.

I think if we stop considering val qwe: @Qualifier String and @get:Qualifier val qwe: String to be equal we could keep only member qualifier in TypeKey and handle all type qualifiers only in equals. That would make code much simpler.

@evant wdyt?

@sergeshustoff sergeshustoff force-pushed the multibind-type-qualifiers branch from 4c99587 to dbda9ad Compare January 13, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support qualifieres in multibinds map keys and set elements.
1 participant