Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Musescore 4 problems #3

Open
ethernetsellout opened this issue Feb 20, 2023 · 13 comments
Open

Musescore 4 problems #3

ethernetsellout opened this issue Feb 20, 2023 · 13 comments

Comments

@ethernetsellout
Copy link

Error after running MS4 w/ xen-tuner:
musescore-xen-tuner-master/xen tuner.qml:247: ReferenceError: Ms is not defined
The line of code:
Fns.init(Accidental, NoteType, SymId, Element, Ms, fileIO, Qt.resolvedUrl("."), curScore);
It seems that Ms is only used in this function to access Ms.CHORD. Other MS4 plugins use Element.CHORD. Indeed, after replacing Ms with Element, the plugin & keyboard shortcuts seem to work, but there's a couple issues:

  • No GUI
  • Moving notes up and down works, but it keeps attaching natural symbols to the note over and over again.

Logs before and after making that change:
before.log
after.log

@euwbah
Copy link
Owner

euwbah commented Feb 20, 2023

Thanks for helping me test it on MS4. Sadly, the logs in MS4 doesn't contain log outputs created by the plugin itself, so it's hard to figure out what is going on, so I can only fix it by guessing.

Apart from the Ms.CHORD issue you've mentioned, I'm trying out these changes:

  • Use pluginType: 'dialog' instead of 'dock': I'm guessing dock type plugins are broken in MS4.
  • Use AccidentalType instead of Accidental when in MS4: I'm following Enum names based off plugins/api/apitypes.h

Do let me know if it works for MS 4

@ethernetsellout
Copy link
Author

Now the GUI is appearing, but changing to AccidentalType is causing reference errors. Nothing aside from the GUI is working.

Also unfortunately there appears to be no way to access the plugin logs, I tried running MuseScore 4 via the command line & they removed the 'plugin script debugger' option.

MuseScore_230220_133941.log

euwbah added a commit that referenced this issue Feb 21, 2023
@euwbah
Copy link
Owner

euwbah commented Feb 21, 2023

Thanks. I've changed some things, could you help me try again?

@ethernetsellout
Copy link
Author

ethernetsellout commented Feb 21, 2023

There were errors where it was trying to open C:/Program Files/MuseScore 4//plugins/musescore-xen-tuner-master/Xen Tuner/tunings/default.txt even though the tunings folder is in musescore-xen-tuner-master. I moved it there, and moving up and down works again with major issues:

@euwbah
Copy link
Owner

euwbah commented Feb 22, 2023

I've just pushed the fixes regarding the incorrect file path, though I still can't figure out what is causing the extra natural accidentals.

Are the natural symbols Accidentals or Symbols? (An accidental will have the 'Accidental' section named in the inspector).

Do the extra natural accidentals only occur on notes without accidentals, or do all notes have an extra natural accidental attached?

What happens when you press up/down? Could you try again after clearing the tuning cache?

Could you do a screen recording of the behaviour you're describing?

Thanks!

@ethernetsellout
Copy link
Author

Sure.

I cleared the tuning cache before this video.

MuseScore4_2023-02-22_01-01-23.mp4

@euwbah
Copy link
Owner

euwbah commented Feb 22, 2023

Ah i see... this is looking bad, and very difficult to debug without the proper log output. Judging from the video, the issue happens somewhere between the attaching of the new accidentals and the removal of unnecessary/extra accidentals, probably due to something being deprecated/renamed in MS4 api.

Just double checking - did you clear the original up/down shortcuts? Remove MuseScore default shortcuts

@ethernetsellout
Copy link
Author

Yes I cleared the up/down shortcuts

euwbah added a commit that referenced this issue Feb 22, 2023
commit 7f25278
Author: euwbah <[email protected]>
Date:   Wed Feb 22 16:28:03 2023 +0800

    Fix broken plugin home dir path

commit 34e3ac7
Author: euwbah <[email protected]>
Date:   Tue Feb 21 17:42:26 2023 +0800

    Addressing #3: Revert to `Accidental`, trying different `modifyNote` approach

commit 45f069b
Author: euwbah <[email protected]>
Date:   Tue Feb 21 01:50:09 2023 +0800

    address #3: change to 'dialog' type & use `AccidentalType` instead.

commit 4b1dc93
Author: euwbah <[email protected]>
Date:   Sat Feb 18 01:23:24 2023 +0800

    readme

commit e2878ab
Author: euwbah <[email protected]>
Date:   Sat Feb 18 01:08:37 2023 +0800

    added polyfills which supposedly makes the plugin work on MS 4

commit fcfebfc
Author: euwbah <[email protected]>
Date:   Wed Feb 15 02:51:18 2023 +0800

    suprt

commit 3c94499
Author: euwbah <[email protected]>
Date:   Wed Feb 15 02:20:25 2023 +0800

    add `Nx:` syntax to change reference note without changing tuning

commit e087d8f
Author: euwbah <[email protected]>
Date:   Wed Feb 15 02:18:36 2023 +0800

    Fix relative tuning nominal incorrect JI fingering calculation

commit ea04e60
Author: euwbah <[email protected]>
Date:   Wed Feb 15 01:48:04 2023 +0800

    readme

commit 5e9f904
Author: euwbah <[email protected]>
Date:   Mon Feb 13 04:04:52 2023 +0800

    add displaysteps to generated HEWM edo

commit dedd28c
Author: euwbah <[email protected]>
Date:   Mon Feb 13 04:04:26 2023 +0800

    add displaysteps to 540edo

commit 056ceec
Author: euwbah <[email protected]>
Date:   Mon Feb 13 04:03:10 2023 +0800

    add 540 edo HEWM

commit 6d7c004
Author: euwbah <[email protected]>
Date:   Mon Feb 13 03:57:41 2023 +0800

    v0.3.2 performance boost

commit 2c1a267
Author: euwbah <[email protected]>
Date:   Mon Feb 13 01:48:28 2023 +0800

    redme

commit 29748c8
Author: euwbah <[email protected]>
Date:   Mon Feb 13 01:47:31 2023 +0800

    readme

commit c6a46ab
Author: euwbah <[email protected]>
Date:   Mon Feb 13 01:42:27 2023 +0800

    readme md lint

commit ad002d5
Author: euwbah <[email protected]>
Date:   Mon Feb 13 01:35:18 2023 +0800

    readme

commit a00bf81
Author: euwbah <[email protected]>
Date:   Mon Feb 13 01:32:12 2023 +0800

    readme

commit b4a4169
Author: euwbah <[email protected]>
Date:   Sun Feb 12 06:45:24 2023 +0800

    redme

commit 5cd0ccb
Author: euwbah <[email protected]>
Date:   Sun Feb 12 06:44:53 2023 +0800

    readme

commit b017fac
Author: euwbah <[email protected]>
Date:   Sun Feb 12 06:34:09 2023 +0800

    readme

commit d5e1d10
Author: euwbah <[email protected]>
Date:   Sun Feb 12 06:31:40 2023 +0800

    readme add guide how to  configure display steps/cents

commit e361b08
Author: euwbah <[email protected]>
Date:   Sun Feb 12 05:52:09 2023 +0800

    fix displaycents decl not working

commit 0c89ed4
Merge: 10d94a6 20470f1
Author: euwbah <[email protected]>
Date:   Sun Feb 12 05:35:02 2023 +0800

    Merge branch 'dev' v0.3.1

commit 10d94a6
Author: euwbah <[email protected]>
Date:   Sun Feb 12 04:31:14 2023 +0800

    update changelog

commit fae0ecd
Author: euwbah <[email protected]>
Date:   Sun Feb 12 04:28:08 2023 +0800

    fix accidentals entered via fingering affect subsequent notes

commit d3d0c91
Author: euwbah <[email protected]>
Date:   Sun Feb 12 01:06:17 2023 +0800

    added comments to the generated HEWM script

commit af6b892
Author: euwbah <[email protected]>
Date:   Sun Feb 12 01:01:07 2023 +0800

    move 311edo to the right folder

commit 1ac9e59
Merge: 248a31e b5f0818
Author: euwbah <[email protected]>
Date:   Sun Feb 12 00:59:11 2023 +0800

    Merge pull request #2 from euwbah/hewm-dev

    Merge v0.3 dev into master

commit 248a31e
Author: euwbah <[email protected]>
Date:   Sat Feb 11 20:27:58 2023 +0800

    Fix 'j' cannot be entered into tempo/expression/fingering
@euwbah
Copy link
Owner

euwbah commented Feb 22, 2023

I've managed to compile MS 4.1.0-dev from source and got it running on my system. I'll figure out a way to get the plugin working using 4.1 :)

euwbah added a commit that referenced this issue Feb 23, 2023
commit 5981b3d
Author: euwbah <[email protected]>
Date:   Thu Feb 23 16:35:54 2023 +0800

    revert to v0.3.3, ms 4 not ready

commit b17df8e
Author: euwbah <[email protected]>
Date:   Thu Feb 23 15:26:11 2023 +0800

    added chromatic/22edo

commit 78f2ad1
Author: euwbah <[email protected]>
Date:   Thu Feb 23 15:06:13 2023 +0800

    add 24edo chromatic staff

commit 7f25278
Author: euwbah <[email protected]>
Date:   Wed Feb 22 16:28:03 2023 +0800

    Fix broken plugin home dir path

commit 34e3ac7
Author: euwbah <[email protected]>
Date:   Tue Feb 21 17:42:26 2023 +0800

    Addressing #3: Revert to `Accidental`, trying different `modifyNote` approach

commit 45f069b
Author: euwbah <[email protected]>
Date:   Tue Feb 21 01:50:09 2023 +0800

    address #3: change to 'dialog' type & use `AccidentalType` instead.

commit 4b1dc93
Author: euwbah <[email protected]>
Date:   Sat Feb 18 01:23:24 2023 +0800

    readme

commit e2878ab
Author: euwbah <[email protected]>
Date:   Sat Feb 18 01:08:37 2023 +0800

    added polyfills which supposedly makes the plugin work on MS 4

commit fcfebfc
Author: euwbah <[email protected]>
Date:   Wed Feb 15 02:51:18 2023 +0800

    suprt

commit 3c94499
Author: euwbah <[email protected]>
Date:   Wed Feb 15 02:20:25 2023 +0800

    add `Nx:` syntax to change reference note without changing tuning

commit e087d8f
Author: euwbah <[email protected]>
Date:   Wed Feb 15 02:18:36 2023 +0800

    Fix relative tuning nominal incorrect JI fingering calculation

commit ea04e60
Author: euwbah <[email protected]>
Date:   Wed Feb 15 01:48:04 2023 +0800

    readme

commit 5e9f904
Author: euwbah <[email protected]>
Date:   Mon Feb 13 04:04:52 2023 +0800

    add displaysteps to generated HEWM edo

commit dedd28c
Author: euwbah <[email protected]>
Date:   Mon Feb 13 04:04:26 2023 +0800

    add displaysteps to 540edo

commit 056ceec
Author: euwbah <[email protected]>
Date:   Mon Feb 13 04:03:10 2023 +0800

    add 540 edo HEWM

commit 6d7c004
Author: euwbah <[email protected]>
Date:   Mon Feb 13 03:57:41 2023 +0800

    v0.3.2 performance boost

commit 2c1a267
Author: euwbah <[email protected]>
Date:   Mon Feb 13 01:48:28 2023 +0800

    redme

commit 29748c8
Author: euwbah <[email protected]>
Date:   Mon Feb 13 01:47:31 2023 +0800

    readme

commit c6a46ab
Author: euwbah <[email protected]>
Date:   Mon Feb 13 01:42:27 2023 +0800

    readme md lint

commit ad002d5
Author: euwbah <[email protected]>
Date:   Mon Feb 13 01:35:18 2023 +0800

    readme

commit a00bf81
Author: euwbah <[email protected]>
Date:   Mon Feb 13 01:32:12 2023 +0800

    readme

commit b4a4169
Author: euwbah <[email protected]>
Date:   Sun Feb 12 06:45:24 2023 +0800

    redme

commit 5cd0ccb
Author: euwbah <[email protected]>
Date:   Sun Feb 12 06:44:53 2023 +0800

    readme

commit b017fac
Author: euwbah <[email protected]>
Date:   Sun Feb 12 06:34:09 2023 +0800

    readme

commit d5e1d10
Author: euwbah <[email protected]>
Date:   Sun Feb 12 06:31:40 2023 +0800

    readme add guide how to  configure display steps/cents

commit e361b08
Author: euwbah <[email protected]>
Date:   Sun Feb 12 05:52:09 2023 +0800

    fix displaycents decl not working

commit 0c89ed4
Merge: 10d94a6 20470f1
Author: euwbah <[email protected]>
Date:   Sun Feb 12 05:35:02 2023 +0800

    Merge branch 'dev' v0.3.1

commit 10d94a6
Author: euwbah <[email protected]>
Date:   Sun Feb 12 04:31:14 2023 +0800

    update changelog

commit fae0ecd
Author: euwbah <[email protected]>
Date:   Sun Feb 12 04:28:08 2023 +0800

    fix accidentals entered via fingering affect subsequent notes

commit d3d0c91
Author: euwbah <[email protected]>
Date:   Sun Feb 12 01:06:17 2023 +0800

    added comments to the generated HEWM script

commit af6b892
Author: euwbah <[email protected]>
Date:   Sun Feb 12 01:01:07 2023 +0800

    move 311edo to the right folder

commit 1ac9e59
Merge: 248a31e b5f0818
Author: euwbah <[email protected]>
Date:   Sun Feb 12 00:59:11 2023 +0800

    Merge pull request #2 from euwbah/hewm-dev

    Merge v0.3 dev into master

commit 248a31e
Author: euwbah <[email protected]>
Date:   Sat Feb 11 20:27:58 2023 +0800

    Fix 'j' cannot be entered into tempo/expression/fingering
euwbah added a commit that referenced this issue Feb 24, 2023
commit 4b96bf2
Author: euwbah <[email protected]>
Date:   Fri Feb 24 12:43:25 2023 +0800

    change file url

commit 5981b3d
Author: euwbah <[email protected]>
Date:   Thu Feb 23 16:35:54 2023 +0800

    revert to v0.3.3, ms 4 not ready

commit b17df8e
Author: euwbah <[email protected]>
Date:   Thu Feb 23 15:26:11 2023 +0800

    added chromatic/22edo

commit 78f2ad1
Author: euwbah <[email protected]>
Date:   Thu Feb 23 15:06:13 2023 +0800

    add 24edo chromatic staff

commit 7f25278
Author: euwbah <[email protected]>
Date:   Wed Feb 22 16:28:03 2023 +0800

    Fix broken plugin home dir path

commit 34e3ac7
Author: euwbah <[email protected]>
Date:   Tue Feb 21 17:42:26 2023 +0800

    Addressing #3: Revert to `Accidental`, trying different `modifyNote` approach

commit 45f069b
Author: euwbah <[email protected]>
Date:   Tue Feb 21 01:50:09 2023 +0800

    address #3: change to 'dialog' type & use `AccidentalType` instead.

commit 4b1dc93
Author: euwbah <[email protected]>
Date:   Sat Feb 18 01:23:24 2023 +0800

    readme

commit e2878ab
Author: euwbah <[email protected]>
Date:   Sat Feb 18 01:08:37 2023 +0800

    added polyfills which supposedly makes the plugin work on MS 4

commit fcfebfc
Author: euwbah <[email protected]>
Date:   Wed Feb 15 02:51:18 2023 +0800

    suprt

commit 3c94499
Author: euwbah <[email protected]>
Date:   Wed Feb 15 02:20:25 2023 +0800

    add `Nx:` syntax to change reference note without changing tuning

commit e087d8f
Author: euwbah <[email protected]>
Date:   Wed Feb 15 02:18:36 2023 +0800

    Fix relative tuning nominal incorrect JI fingering calculation

commit ea04e60
Author: euwbah <[email protected]>
Date:   Wed Feb 15 01:48:04 2023 +0800

    readme

commit 5e9f904
Author: euwbah <[email protected]>
Date:   Mon Feb 13 04:04:52 2023 +0800

    add displaysteps to generated HEWM edo

commit dedd28c
Author: euwbah <[email protected]>
Date:   Mon Feb 13 04:04:26 2023 +0800

    add displaysteps to 540edo

commit 056ceec
Author: euwbah <[email protected]>
Date:   Mon Feb 13 04:03:10 2023 +0800

    add 540 edo HEWM

commit 6d7c004
Author: euwbah <[email protected]>
Date:   Mon Feb 13 03:57:41 2023 +0800

    v0.3.2 performance boost

commit 2c1a267
Author: euwbah <[email protected]>
Date:   Mon Feb 13 01:48:28 2023 +0800

    redme

commit 29748c8
Author: euwbah <[email protected]>
Date:   Mon Feb 13 01:47:31 2023 +0800

    readme

commit c6a46ab
Author: euwbah <[email protected]>
Date:   Mon Feb 13 01:42:27 2023 +0800

    readme md lint

commit ad002d5
Author: euwbah <[email protected]>
Date:   Mon Feb 13 01:35:18 2023 +0800

    readme

commit a00bf81
Author: euwbah <[email protected]>
Date:   Mon Feb 13 01:32:12 2023 +0800

    readme

commit b4a4169
Author: euwbah <[email protected]>
Date:   Sun Feb 12 06:45:24 2023 +0800

    redme

commit 5cd0ccb
Author: euwbah <[email protected]>
Date:   Sun Feb 12 06:44:53 2023 +0800

    readme

commit b017fac
Author: euwbah <[email protected]>
Date:   Sun Feb 12 06:34:09 2023 +0800

    readme

commit d5e1d10
Author: euwbah <[email protected]>
Date:   Sun Feb 12 06:31:40 2023 +0800

    readme add guide how to  configure display steps/cents

commit e361b08
Author: euwbah <[email protected]>
Date:   Sun Feb 12 05:52:09 2023 +0800

    fix displaycents decl not working

commit 0c89ed4
Merge: 10d94a6 20470f1
Author: euwbah <[email protected]>
Date:   Sun Feb 12 05:35:02 2023 +0800

    Merge branch 'dev' v0.3.1

commit 10d94a6
Author: euwbah <[email protected]>
Date:   Sun Feb 12 04:31:14 2023 +0800

    update changelog

commit fae0ecd
Author: euwbah <[email protected]>
Date:   Sun Feb 12 04:28:08 2023 +0800

    fix accidentals entered via fingering affect subsequent notes

commit d3d0c91
Author: euwbah <[email protected]>
Date:   Sun Feb 12 01:06:17 2023 +0800

    added comments to the generated HEWM script

commit af6b892
Author: euwbah <[email protected]>
Date:   Sun Feb 12 01:01:07 2023 +0800

    move 311edo to the right folder

commit 1ac9e59
Merge: 248a31e b5f0818
Author: euwbah <[email protected]>
Date:   Sun Feb 12 00:59:11 2023 +0800

    Merge pull request #2 from euwbah/hewm-dev

    Merge v0.3 dev into master

commit 248a31e
Author: euwbah <[email protected]>
Date:   Sat Feb 11 20:27:58 2023 +0800

    Fix 'j' cannot be entered into tempo/expression/fingering
@defaultuserQ
Copy link

hopefully you'll get it working

@EaryChow
Copy link

EaryChow commented Feb 9, 2024

@euwbah I commented about the problem on "retuning doesn't work on notes with microntonal accidentals" in another issue page, and I found the reason for it. After thinking it through, I think this issue page is more suitable for discussing this, since it's a MS4 related problem in general.

Basically MS4 supports microtonal accidental playback, but it's under 24edo assumption.
musescore/MuseScore#21391 (comment)
So if I want to retune these notes to 31 edo with this plugin, it will fail miserably. Until MS actually support the various tuning systems (which would be a distant future), we need to first counter the 24 edo assumed playback, before adding the tuning values on top.

TL;DR: Basically the same tuning cent values in MS3 are now "incorrect" in MS4.

@EaryChow
Copy link

For people looking for a temp solution before the author here fixes things.

Use the pitch up/down plugin from this old repo here (since the up and down pitch in this new plugin doesn't seem to work for me):
https://github.com/euwbah/musescore-microtonal-edo-plugin/tree/v4-dev

And use Keenan Pepper's tuning plugin from here:
https://github.com/keenanpepper/musescore-xentuner

Only problem is Keenan Pepper's tuning pluggin doesn't have many tuning files in there. It works for me trying to do 31edo though. The ones in KP's seem to have compensated for MS4's 24edo assumption already.

@wolftune
Copy link

wolftune commented Sep 11, 2024

I tried to use this with latest MuseScore Studio 4.4.1 and what I got was only unnamed plugins that won't run. I would love to have this working with MuseScore 4. Until then, I'm stuck on MuseScore 3.

EDIT: I'm going to try 4.3, the 4.4 broke plugins and they need updating. I hope this can get updated to Qt6 for compatibility (or make a version for that or whatever is appropriate). See https://musescore.org/en/node/367897 and https://musescore.org/en/node/337468

UPDATE: I was able to see the name in 4.3 but when I run "Start Xen Tuner" nothing happens. I see no indication it is running, and pitch-up and pitch-down aren't working.

So, it looks like this needs both the Qt6 updates and other changes to be MS4 compatible.

FWIW, Keenan's plugin is no solution for me, I care about the notation flexibility not just playback.

I'm happy to keep testing and helping as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants