Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ethpm URIs without specified package versions #89

Open
njgheorghita opened this issue Feb 17, 2020 · 0 comments
Open

Support ethpm URIs without specified package versions #89

njgheorghita opened this issue Feb 17, 2020 · 0 comments

Comments

@njgheorghita
Copy link
Contributor

What was wrong?

The cli supports ethpm URIs like...
ethpm://ens.packages.eth : specify only a registry
ethpm://ens.packages.eth/[email protected] : specify a package release on a registry
ethpm://ens.packages.eth/[email protected]/deployments/Token: specify a certain asset within a package

From a UX point of view it would be nice to support
ethpm://ens.packages.eth/package - rather than requiring a version to be specified.

Since ethpm does not enforce semver, if this kind of uri is used - then a list of all detected versions should be printed - giving the user the chance to choose what version they want to install/activate (similar to how this is handled in ethpm update).

How can it be fixed?

  • parse_registry_uri in web3.py will need to be updated. currently if an ethpm uri contains a package name a version is also required.
  • an input() prompt will be required for both ethpm activate and ethpm install that allows the user to specify a version from a list of available versions (similar to ethpm update)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant