Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to compiler with SRI #334

Closed
fulldecent opened this issue Jan 21, 2019 · 1 comment
Closed

Link to compiler with SRI #334

fulldecent opened this issue Jan 21, 2019 · 1 comment

Comments

@fulldecent
Copy link

Currently in the README:

Add the version of solc you want to use into index.html:

<script type="text/javascript" src="https://solc-bin.ethereum.org/bin/{{ SOLC VERSION }}.js"></script>

(Alternatively use https://solc-bin.ethereum.org/bin/soljson-latest.js to get the latests version.)

This is not a security best practice. We should promote security best practices by providing a list of specific URLs and SRI hashes. Some people may prefer convenience over security and not use SRI, we can explain to them that they are taking on more risk that way.

@r0qs
Copy link
Member

r0qs commented Mar 9, 2023

Fixed by #658.

@r0qs r0qs closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Implement
Development

No branches or pull requests

3 participants