Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip pyethash dependency in Windows #395

Closed
carver opened this issue Feb 23, 2018 · 1 comment
Closed

Skip pyethash dependency in Windows #395

carver opened this issue Feb 23, 2018 · 1 comment

Comments

@carver
Copy link
Contributor

carver commented Feb 23, 2018

  • py-evm Version: 0.2.0a11
  • OS: win

What is wrong?

pyethash won't build on Windows, and probably won't anytime soon. See Consensys/ethjsonrpc#5

The ethash code is C99, which is not well-supported under Windows.

This makes it impossible to install py-evm on Windows, as well as any package that depends on py-evm like the test suite in web3.py. (See ethereum/web3.py#166)

How can it be fixed

A couple options come to mind:

  1. Skip the pyethash install on Windows, so that Windows users can install the EVM without mining capability
  2. Move the pyethash dependency to an "extra" called something like mining.

Number 1 seems better, because it supports mining with a default installation, in non-Windows environments. Number 2 requires an install like pip install py-evm[mining] to support mining.

Does anyone see problems with 1 or 2, or a better solution?

@carver
Copy link
Contributor Author

carver commented Feb 23, 2018

Does anyone see problems with 1 or 2

So, yeah, it's used for pow verification also. So... this is a no-go until pyethash (or some alternative) is made to work on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant