Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken onlymanyowners #83

Open
lorien opened this issue Oct 15, 2017 · 1 comment
Open

Broken onlymanyowners #83

lorien opened this issue Oct 15, 2017 · 1 comment

Comments

@lorien
Copy link

lorien commented Oct 15, 2017

I think this https://github.com/ethereum/dapp-bin/blob/master/wallet/wallet.sol#L48
should be

modifier onlymanyowners(bytes32 _operation) {
    if (confirmAndCheck(_operation)) {
        _;
    }
}
@izetex
Copy link

izetex commented Oct 20, 2017

I agree, the wallet is broken on 4.X solidity compiler
Method execute is interrupted by requires and no Confirmation request created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants