-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce folder numbering #203
Comments
May i work on this issue? |
Hey @ShubhSensei, are you still interested in working on this? If so, here is my thinking for what we should do:
I think we should only check for uniqueness, and not for any type of ordering or incrementing pattern. This is because:
@maurelian what do you think of this spec? |
Yes @mds1 of course... I'm on it 🫡 |
Thanks, assigned! And apologies for the slow response here, I had meant to come back to this after #152 was addressed but never did 😅 |
The spec LGTM yes. |
How do I run this script in CI? @mds1 |
I left a comment on the PR with this info |
We should add a check in CI to ensure that within a task folder, the numbering of tasks is increasing and does not overlap.
ie. #200 currently introduces a new dir
tasks/sep/009-fpac-upgrade
which is incorrect since there is already atasks/sep/009-presigned-pause
.This happens easily due to race conditions between new tasks, so we should automatically check for it.
The text was updated successfully, but these errors were encountered: