Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-6110: Validator Deposits on Chain #505

Open
refcell opened this issue Jan 15, 2025 · 3 comments
Open

EIP-6110: Validator Deposits on Chain #505

refcell opened this issue Jan 15, 2025 · 3 comments
Labels
A-execution Area: execution layer H-isthmus Hardfork: change is planned for Isthmus upgrade H-pectra Hardfork: change planned for Pectra (L1) upgrade U-node Upgrade: involving changes to node component (cl, el, etc.)

Comments

@refcell
Copy link
Contributor

refcell commented Jan 15, 2025

Description

EIP-6110 includes validator deposits in the execution layer, removing deposit voting from the consensus layer.

From @protolambda:

Can consider an upgrade deposit-tx, with same sender as the pre-determined example tx, to ensure the contract is deployed.
The contract is the same, but effectively no-op, not affecting the block.

References

@refcell refcell added the H-pectra Hardfork: change planned for Pectra (L1) upgrade label Jan 15, 2025
@emhane emhane added A-op-reth U-node Upgrade: involving changes to node component (cl, el, etc.) labels Jan 15, 2025
@protolambda
Copy link
Contributor

IMO we should not use an upgrade-tx. We have done this for contracts that are expected to work with op-stack, like the beacon-block-roots accumulator. But the beacon deposit contract, as well as other pectra-requests-generating contracts, are not expected to work. We should ignore them. It's much more safe to just change the request generation to not include requests of type X (see EIPs) than to try and change the bytecode to something that happens to not insert it. Especially since some of these pectra contracts can be deployed permissionlessly ahead of the op-stack upgrade, and we don't want to modify bytecode.

@emhane
Copy link
Member

emhane commented Jan 17, 2025

are changes required to op-node @protolambda ?

@emhane emhane added the H-isthmus Hardfork: change is planned for Isthmus upgrade label Jan 17, 2025
@protolambda
Copy link
Contributor

@emhane no op-node changes required for this one. Although, for the more generic requests-handling, it would be good to make the op-node abort block-building if the engine-API ever returns a block with a non-empty requests list. To ensure we don't accidentally build the block if the EL / block-builder API has some bug.

And this then also means to not deploy an upgrade-tx for this contract. See above comment.
Just a tiny EL diff, by not putting this type of request in the block if it's an op-stack chain, regardless of what happens in the EVM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-execution Area: execution layer H-isthmus Hardfork: change is planned for Isthmus upgrade H-pectra Hardfork: change planned for Pectra (L1) upgrade U-node Upgrade: involving changes to node component (cl, el, etc.)
Projects
None yet
Development

No branches or pull requests

3 participants