Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit bootstrap vs create-nx-workspace #215

Open
luxaritas opened this issue Mar 7, 2023 · 0 comments
Open

Revisit bootstrap vs create-nx-workspace #215

luxaritas opened this issue Mar 7, 2023 · 0 comments
Labels
priority: p3/standard Enhancement with nominal value or bug with nominal impact scope: bootstrap scope: nx-plugin size: md type: enhancement New feature or request

Comments

@luxaritas
Copy link
Member

Describe your idea

We should reconsider whether or not we need our separate @eternagame/boostrap package or if we can move back to relying on create-nx-workspace

Motivation

In #41 (planned from #24), we decided to create our own repo generator for a few reasons:

  • Control over Nx version, particularly in the context of applying migrations to our layout
  • Avoiding surfacing options we wind up not supporting/overriding
  • The ability to show generator prompts in our preset
  • Needing to overwrite a fair amount of the files that were initialized that aren't valid for our preferred setup/layout

Recent versions of Nx have changed some of the situation:

  • Preset generators can now have prompts
  • Nx has done work on being less opinionated, eg through first-class support of package-based/non-integrated layouts, encapsulated mode, etc. More of the autogenerated files have moved to specific plugins, and Nx should be more resilient to our preferred layout.

Additionally, we could consider whether our plugin and configs could better support the integrated monorepo style.

This may or may not actually be something we can/should do, or may require some additional adjustments to Nx before we can consider it (namely, it looks like nx new always uses the integrated style for custom presets?)

Proposed Solution

No response

Other Information

No response

@luxaritas luxaritas added type: enhancement New feature or request scope: nx-plugin size: md priority: p3/standard Enhancement with nominal value or bug with nominal impact scope: bootstrap labels Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3/standard Enhancement with nominal value or bug with nominal impact scope: bootstrap scope: nx-plugin size: md type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant