Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

espressif-IDE editor lacks code refactor tools (IEP-1393) #1102

Open
emaayan opened this issue Dec 20, 2024 · 2 comments
Open

espressif-IDE editor lacks code refactor tools (IEP-1393) #1102

emaayan opened this issue Dec 20, 2024 · 2 comments
Assignees

Comments

@emaayan
Copy link

emaayan commented Dec 20, 2024

Describe the bug
A clear and concise description of what the bug is.

this is the result of switching espressif switching to the new LSP code, because those refactors exists in the legacy code,
I've already opened an issue with cdt eclipse-cdt/cdt-lsp#386 but they partially referred me to clangd
I'm not sure how can this be solved, but considering eclispe's massive refactoring abilities it's amazing it's being downgraded to visual studio's refactor feature just because you switched editors.

To Reproduce
Steps to reproduce the behavior:

  1. mark a code block
  2. RCM on it, and highlight refactor

Expected behavior
having access to code factor tools

Screenshots
image
image

@github-actions github-actions bot changed the title espressif-IDE editor lacks code refactor tools espressif-IDE editor lacks code refactor tools (IEP-1393) Dec 20, 2024
@alirana01
Copy link
Collaborator

Hi @emaayan
Thanks for bringing forward the issue as you mentioned LSP4E project lacks some integrations mentioned by the bug reported by you on cdt-lsp. We are working on such issues that are coming forward via Espressif-IDE since we started rolling out the LSP editor. One main reason to do this was to move to clangd based indexing as the CDT indexer mentioned by Jonah was not indexing things properly and was causing issues. Along with that we are trying to bridge the gap with old editor. We appreciate your patience and understanding in the matter

@alirana01 alirana01 self-assigned this Jan 7, 2025
@emaayan
Copy link
Author

emaayan commented Jan 9, 2025

Hi @emaayan Thanks for bringing forward the issue as you mentioned LSP4E project lacks some integrations mentioned by the bug reported by you on cdt-lsp. We are working on such issues that are coming forward via Espressif-IDE since we started rolling out the LSP editor. One main reason to do this was to move to clangd based indexing as the CDT indexer mentioned by Jonah was not indexing things properly and was causing issues. Along with that we are trying to bridge the gap with old editor. We appreciate your patience and understanding in the matter

i suspect this indexer maybe causing issues as well, there have been many cases where for some reason it would be "out of sync" with the code and i will get a compiler error where there should be none
even cases such commenting like
ESP_LOGI(TAG,"HELLO)
if i do
//ESP_LOGI(TAG,"HELLO)
i get a compiler error
then i go back do
// ESP_LOGI(TAG,"HELLO)
and it's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants