Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansi_color_converter no longer necessary on windows10 (IDFGH-10726) #2

Open
phed opened this issue Jul 25, 2023 · 3 comments
Open

ansi_color_converter no longer necessary on windows10 (IDFGH-10726) #2

phed opened this issue Jul 25, 2023 · 3 comments

Comments

@phed
Copy link

phed commented Jul 25, 2023

Both miniterm and idf_monitor tries to convert terminal escape codes into windows terminal calls. This is no longer necessary as the default installed windows terminal now supports VT100.

This means one can have much more complex terminal interactions. miniterm already makes the necessary calls to enable it.

I haven't found a simple way to disable it, so I've just modified it to pass through the serial output. I am not familiar enough with the code to make a patch.

More about the windows terminal VT100 support here:
https://learn.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences

@github-actions github-actions bot changed the title ansi_color_converter no longer necessary on windows10 ansi_color_converter no longer necessary on windows10 (IDFGH-10726) Jul 25, 2023
@dobairoland
Copy link
Collaborator

Thanks @phed for raising this suggestion. One should be always cautious with dropping support for older technologies. We will give this a careful consideration....

@phed
Copy link
Author

phed commented Jul 26, 2023

Happy to hear. One can detect if the full VT100 support exists through the mechanism suggested under "Example of Enabling Virtual Terminal Processing". Of course one has to check if any possible initialization done by miniterm does not conflict with such a detection.

@fhrbata
Copy link
Collaborator

fhrbata commented Jul 31, 2023

Hello, IIUC the console can be still put into legacy mode. I don't know about a use case for this, but I'm not a windows user neither. That being said, if someone needs to use, for whatever reason, legacy console, he may run into problems with idf monitor. Just my $0.02.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants