Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Binary name not correct in wokwi.toml. #151

Closed
hlf20010508 opened this issue Mar 23, 2024 · 2 comments · Fixed by #152
Closed

Binary name not correct in wokwi.toml. #151

hlf20010508 opened this issue Mar 23, 2024 · 2 comments · Fixed by #152

Comments

@hlf20010508
Copy link
Contributor

In wokwi.toml, it uses crate_name as binary name.
But in Cargo.toml, it uses project-name.
This results in file not found.

For example, if the project name is esp-test, after cargo build, it will build out a binary named esp-test, but wokwi will search esp_test.

If I change it to esp_test in Cargo.toml, the output binary name will be esp_test which is correct for wokwi.

@SergioGasquez
Copy link
Member

I guess that we should use {{project-name}} instead of {{crate_name}, if you'd like to open a PR it would be appreciated, if not, I'll test it and create a PR on Monday.

hlf20010508 added a commit to hlf20010508/esp-template that referenced this issue Mar 23, 2024
Use {{project-name}} instead of {{crate_name}} in wokwi.toml.
@hlf20010508
Copy link
Contributor Author

Ok, I've opened a PR #152.

@SergioGasquez SergioGasquez linked a pull request Mar 25, 2024 that will close this issue
SergioGasquez pushed a commit that referenced this issue Mar 25, 2024
Use {{project-name}} instead of {{crate_name}} in wokwi.toml.
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants