Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UART: The calling order of with_tx() and with_rx() builder functions might matter #2911

Closed
JurajSadel opened this issue Jan 8, 2025 · 0 comments · Fixed by #2914
Closed
Assignees
Labels
bug Something isn't working peripheral:uart UART peripheral status:needs-attention This should be prioritized

Comments

@JurajSadel
Copy link
Contributor

let uart = Uart::new(peripherals.UART1, uart::Config::default())
            .unwrap()
            .with_tx(tx)
            .with_rx(rx);

and

let uart = Uart::new(peripherals.UART1, uart::Config::default())
            .unwrap()
            .with_rx(rx)
            .with_tx(tx);

could produce different results as discovered in #2132 (comment) and re-appeared in #2904.

Affected chip: ESP32

@JurajSadel JurajSadel added bug Something isn't working status:needs-attention This should be prioritized peripheral:uart UART peripheral labels Jan 8, 2025
@github-project-automation github-project-automation bot moved this to Todo in esp-rs Jan 8, 2025
@bugadani bugadani self-assigned this Jan 8, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working peripheral:uart UART peripheral status:needs-attention This should be prioritized
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants