Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Request: Correct types for configs #52

Open
1 task
burtek opened this issue Nov 8, 2024 · 3 comments · May be fixed by #59
Open
1 task

Change Request: Correct types for configs #52

burtek opened this issue Nov 8, 2024 · 3 comments · May be fixed by #59
Labels
accepted enhancement New feature or request

Comments

@burtek
Copy link

burtek commented Nov 8, 2024

Environment

ESLint version: 9.14.0
@eslint/json version: 0.6.0
Node version: 20.9.0
npm version: 10.1.0
Operating System: LMDE 6, kernel 6.1.0-26-amd64

What problem do you want to solve?

The json plugin typings is wrong as it exports config property as {}
Image
This causes errors in IDE:
Image

What do you think is the correct solution?

The configs property of the plugin should be typed correctly.

Participation

  • I am willing to submit a pull request for this change.

Additional comments

No response
@burtek burtek added the enhancement New feature or request label Nov 8, 2024
@burtek burtek changed the title Change Request: (fill in) Change Request: Correct types for configs Nov 8, 2024
@burtek burtek mentioned this issue Nov 8, 2024
Open
@fasttime fasttime added this to Triage Nov 12, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Nov 12, 2024
@fasttime fasttime removed the status in Triage Nov 12, 2024
@fasttime fasttime moved this to Needs Triage in Triage Nov 12, 2024
@fasttime fasttime moved this from Needs Triage to Triaging in Triage Nov 12, 2024
@fasttime fasttime linked a pull request Nov 12, 2024 that will close this issue
Open
1 task
@fasttime
Copy link
Member

Thanks for reporting this problem @burtek. I can confirm that the configs property of the plugin is currently typed as an empty object. I've submitted a pull request that shoul fix the types: #59.

@fasttime fasttime moved this from Triaging to Implementing in Triage Nov 12, 2024
@burtek
Copy link
Author

burtek commented Nov 13, 2024 •
edited
Loading

@fasttime btw, same probably needs to be done in eslint/markdown repo (https://github.com/eslint/markdown/blob/main/src/index.js), but I'm not using it so just mentioning it

@fasttime
Copy link
Member

@burtek yes, we should fix also eslint/markdown and eslint/css. I'll take care of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted enhancement New feature or request
Projects
Triage
Status: Implementing
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: expose plugin.configs in types eslint/json
2 participants
@burtek @fasttime