feat: support languages json/markdown #151
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
changed the title
aladdin-add
commented
Nov 4, 2024
lib/config-generator.js
Outdated
| importContent += "import pluginReact from \"eslint-plugin-react\";\n"; | ||
| exportContent += " pluginReact.configs.flat.recommended,\n"; | ||
| // the default is commonmark | ||
| exportContent += " {files: [\"**/*.md\"], language: \"markdown/gfm\"},\n"; |
There was a problem hiding this comment.
A better UX if it could export a predefined config for gfm?
aladdin-add
commented
Nov 4, 2024
| ] | ||
| } | ||
| ]; | ||
| Object.assign(this.answers, await enquirer.prompt(langQuestions)); |
There was a problem hiding this comment.
didn't use skip - as there is a known issue when using multi-selection: enquirer/enquirer#298
mdjermanovic
reviewed
Nov 6, 2024
mdjermanovic
reviewed
Nov 7, 2024
|
I think this part described in #148 isn't implemented:
|
aladdin-add
requested review from
mdjermanovic,
harish-sethuraman and
nzakas
and removed request for
harish-sethuraman
mdjermanovic
reviewed
Nov 8, 2024
Co-authored-by: Milos Djermanovic <[email protected]>
mdjermanovic
reviewed
Nov 8, 2024
| @@ -12,6 +12,7 @@ const compat = new FlatCompat({baseDirectory: __dirname, recommendedConfig: plug | |||
|
|
|||
| /** @type {import('eslint').Linter.Config[]} */ | |||
| export default [ | |||
| {ignores: ["**/*.js", "**/*.cjs", "**/*.mjs"]}, | |||
There was a problem hiding this comment.
Tests should be updated to pass languages: ["javascript"]?
mdjermanovic
reviewed
Nov 8, 2024
Co-authored-by: Milos Djermanovic <[email protected]>
|
A problem is that most plugin configs (including For example: Generated config file: import pluginJs from "@eslint/js";
import json from "@eslint/json";
/** @type {import('eslint').Linter.Config[]} */
export default [
pluginJs.configs.recommended,
{files: ["**/*.json"], language: "json/json", ...json.configs.recommended},
]; |
|
Yes, I was able to repro! Is it the expected behavior? My understanding is that it should only be applied to and I'm getting the same error even if I added import pluginJs from "@eslint/js";
import json from "@eslint/json";
/** @type {import('eslint').Linter.Config[]} */
export default [
{files: ["**/*.{js,mjs,cjs}"]},
pluginJs.configs.recommended,
{files: ["**/*.json"], language: "json/json", ...json.configs.recommended},
]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #148