Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust dark mode palette #72

Open
1 of 3 tasks
collinmesser opened this issue Oct 10, 2019 · 9 comments · May be fixed by #100
Open
1 of 3 tasks

Adjust dark mode palette #72

collinmesser opened this issue Oct 10, 2019 · 9 comments · May be fixed by #100
Assignees
Labels
hacktoberfest Good Hacktoberfest issues 🚀 enhancement New feature or request 🆘 help-wanted Extra attention is needed up-for-grabs Free for the taking
Milestone

Comments

@collinmesser
Copy link
Member

Type of issue

  • Bug
  • Feature/Enhancement
  • Question

Description

I'd like to adjust the dark mode palette to be a little more user-friendly. Possibly slightly darker main color and full support across the site. The colors should pass accessibility tests for visibility.

Here are some links to help with creating a palette. I'm fine if someone just wants to create the palette without actually implementing it as well. You could demo the palette in the comments.

Steps to Reproduce

  1. [First Step]
  2. [Second Step]
  3. [and so on...]

Expected behavior: [What you expected to happen]

Actual behavior: [What actually happened]

Versions

ONLY if different than Master currently.
You can get this information from executing npm version.

@collinmesser collinmesser added 🚀 enhancement New feature or request 🆘 help-wanted Extra attention is needed labels Oct 10, 2019
@collinmesser collinmesser added this to the 4.0 milestone Oct 10, 2019
@collinmesser collinmesser added up-for-grabs Free for the taking hacktoberfest Good Hacktoberfest issues labels Oct 12, 2019
@lucasjs
Copy link
Member

lucasjs commented Oct 12, 2019

Hey @collinmesser. I could make that changes. I'm a front-end developer, designer and a11y advocate. 😃

@collinmesser
Copy link
Member Author

Sure, I'd love to see what you come up with. Feel free to assign this issue to yourself and a bot will automatically make a branch for you. Let me know if you have any questions.

@lucasjs
Copy link
Member

lucasjs commented Oct 13, 2019

Sure, I'd love to see what you come up with. Feel free to assign this issue to yourself and a bot will automatically make a branch for you. Let me know if you have any questions.

I can't assign. Could you do that for me?

@lucasjs lucasjs self-assigned this Oct 14, 2019
@lucasjs
Copy link
Member

lucasjs commented Oct 14, 2019

@collinmesser I'm studying about the UX. What do you think about a theme switch on the top bar?

@collinmesser
Copy link
Member Author

@lucasjs You can check out the current build here https://esfiddle.netlify.com. There is a theme switcher on the top bar, but if you'd like to adjust it feel free.

@lucasjs
Copy link
Member

lucasjs commented Oct 14, 2019

That's awesome! Thanks!

@lucasjs
Copy link
Member

lucasjs commented Oct 30, 2019

Sorry for the late response!
I've been studying a lot about dark and light mode.
Now I'm working on it, branch add-darkmode.

@lucasjs lucasjs linked a pull request Oct 30, 2019 that will close this issue
8 tasks
@collinmesser
Copy link
Member Author

How's this going for you @lucasjs? do you need anything from me at all?

@lucasjs
Copy link
Member

lucasjs commented Nov 11, 2019

@collinmesser I'm studying the colors and I will finish it in a few days. I'll need a review after that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Good Hacktoberfest issues 🚀 enhancement New feature or request 🆘 help-wanted Extra attention is needed up-for-grabs Free for the taking
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants